Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paused and Seeding colors are very similar #162

Closed
IevgenSobko opened this issue Feb 21, 2021 · 16 comments
Closed

Paused and Seeding colors are very similar #162

IevgenSobko opened this issue Feb 21, 2021 · 16 comments

Comments

@IevgenSobko
Copy link
Contributor

Paused and Seeding colors are very similar
When using a dark theme and lowering the brightness of the laptop screen it is hard to distinguish Paused and Seeding torrents because of very similar colors.
I guess we need to change them to be much more distinguishable.
2021-02-21__23-33-01

@WDaan
Copy link
Collaborator

WDaan commented Feb 26, 2021

Don't you mean 'done' & 'seeding'? Because those are the 2 shown in the picture, if I'm not wrong. :)

But you are right, feel free to make a suggestion about what it should be.

@IevgenSobko
Copy link
Contributor Author

IevgenSobko commented Feb 26, 2021

Yep, these are done and seeding as well as done and seeding paused
I checked not done and paused and it is shown as some shade of gray or white.
I would expect every paused should have the same color not depending on the completeness status.
2021-02-26__09-52-32

@WDaan
Copy link
Collaborator

WDaan commented Feb 26, 2021

They're to similar indeed.
I guess we should let the public decide which colors we're going with 😝

So anyone who reads this, feel free to make suggestions or a poll or something :)

@IevgenSobko
Copy link
Contributor Author

@WDaan how about making all paused have the same color(not dependent on completeness status)?
Do you agree with this?

@WDaan
Copy link
Collaborator

WDaan commented Feb 26, 2021

these are the only torrent states (with color) that exist.... there should be only 1 type of paused
image

@IevgenSobko
Copy link
Contributor Author

But there are 2 see my last screenshot.
And it depends on completeness status.
If torrent is not complete you get this grey color that I think is correct.
If torrent completed and seeding and you pause it you get second row in my screenshot.

@IevgenSobko
Copy link
Contributor Author

Woops. Accidentally closed in mobile application of GitHub.
Sry 😭

@WDaan
Copy link
Collaborator

WDaan commented Feb 26, 2021

Okaay, it took me a while to understand what you were trying to say ... sorry 😅
Yes, pausedUp is used to mark is at 'done', I thought it was the same way that the default WebUI decides it.
You're saying that pausedUp should result in paused as well?? But than there is no way to know if a torrent is actually done?

image

@IevgenSobko
Copy link
Contributor Author

IevgenSobko commented Feb 26, 2021

I played with original UI and seems you are correct about they distinguish paused depending on the completeness status.
For me it is important to know whether torrent is paused or not because I download torrent just few hours but leave it to seed for a months if not years.
I such a situation I think 🤔 just making seeding and done distinguished by colors would be ok if we want to follow original qbittorent ideas.

@IevgenSobko
Copy link
Contributor Author

I suggest something like the following color for done state.
Green indicates it is done and dark shade means it is doing nothing(paused)
2021-02-26__11-11-52
But it might not play well with dark or bright theme.
I'll check it in a few hours when free.

@IevgenSobko
Copy link
Contributor Author

@WDaan btw what IDE r u using?

@WDaan
Copy link
Collaborator

WDaan commented Feb 26, 2021

PhpStorm & VSCode :)

@IevgenSobko
Copy link
Contributor Author

IevgenSobko commented Feb 26, 2021

I think following color might work
$torrent-done: #16573e;
It works for me even with night color enabled and the lowest screen brightness in contrary to the current color.
2021-02-26__12-54-17 2021-02-26__12-54-39

@WDaan
Copy link
Collaborator

WDaan commented Feb 26, 2021

The destinction between the colors is a lot better, yes :)

@IevgenSobko
Copy link
Contributor Author

If noone objects feel free to incorporate this color in next release.
It doesn't make sense to open merge request for a such big change 🤣

@WDaan
Copy link
Collaborator

WDaan commented Feb 26, 2021

If someone wants to get mentioned as a contributor perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants