New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto releasing ci #146
Conversation
Amazing! This is what I've been wanting/looking for for a long time and more! Questions:
EDIT: I quickly tested it, looks awesome! |
Firstly, the versions get bumps based on the commit messages. In this case, that would mean PR titles since we use squash and merge method here (which is best is great!). That being said, there are two ways. One is using the main commit message or using the commit body:
Only for major bumps, the commit (PR) body will do this. I usually just use the former. You can see more on this here. |
Also, if this gets merged in, I don't mind being on stand by to ensure everything goes smoothly. You just let me know what else you need from me and I can provide some examples or explanations! |
I can update the README as well since some of the installation will change. Mostly just naming. |
Thanks! I also monitor it a little bit as well. I think the only changes are the name of the .zip & the path of the latest-release branch. It seems like you directly upload what's inside of the public folder. Very smart utilisation of the github-pages action BTW! Also, I think that de README in the latest-release branch will disappear on a new release? |
Yep! Thanks right. I figure that what we put in the README should be sufficient. If not, we can figure out a way to get it in there.
This should be fine! I believe it will be publishing just the |
Okay! I think it's good to go. Let me know if you need anything else. |
I also wanted to remove the old release script in this PR, because its kind off related |
Great. Thanks for doing it. Commit looks great too 😉 |
No, thank you! This is a big step in the right direction. It shows that the project is maturing a little bit. |
The workflows help a ton. I'll make a comment on the PR that gets created after this is merged. |
There seems to be a small mistake somewhere in both workflows EDIT: fixed now |
Oh whoops. Thank you! |
Description
I know there are a lot of changes and may warrant a bit of speculation, but I will try elaborate on what's going on here in a list below.
google-github-actions/release-please-action
CHANGELOG
based on Conventional Commits. This isn't necessary, but is cool feature.latest-release
branch (more on this later).package.json
.vuetorrent.zip
rather thanrelease.zip
.latest-release
README
). But we can easily update the project'sREADME
, to show how to use branch.master
and pull requests tomaster
in my opinion.Kind of did this on a whim, but figured it would be really good to have something easier to manage!
Take a look at one of my repos and see how it publishes:
Feel free to ask any questions!