Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do you think about following speed cards? #141

Closed
IevgenSobko opened this issue Jan 31, 2021 · 6 comments
Closed

What do you think about following speed cards? #141

IevgenSobko opened this issue Jan 31, 2021 · 6 comments
Labels
Idea Nor Bug nor feature, but a suggestion or Idea. Can be moved to discussions?

Comments

@IevgenSobko
Copy link
Contributor

What do you think about following speed cards?
2021-01-31__13-47-01

@WDaan
Copy link
Collaborator

WDaan commented Jan 31, 2021

I like them, but design is not my strong suit 😅
It's great that there's a lot of room for the speed itself.
But the cards do take up a lot of vertical space in the sidebar.

Any reason for this change?
I thought the current ones were great & the wrapping issues fixed by rounding the values

Thanks for willing to contribute to this project!

@WDaan WDaan added Idea Nor Bug nor feature, but a suggestion or Idea. Can be moved to discussions? UI labels Jan 31, 2021
@IevgenSobko
Copy link
Contributor Author

The current implementation is OK.
I just playing with my ideas before you implemented the current look.
Something like circles :)
2021-01-31__14-23-08
Just posting these ideas we might implement in case of redesign

@IevgenSobko
Copy link
Contributor Author

IevgenSobko commented Jan 31, 2021

What would you say about the following pill?
I decreased the space taken by using just 2 rows.
Also increased font size to clearly see the speed on laptop and mobile
2021-01-31__18-51-29
It feels better to me than current online. Especially for 0 Download speed.
2021-01-31__18-59-58

@IevgenSobko
Copy link
Contributor Author

Or just following current rectangles with rounded corner
2021-01-31__19-29-58

@LukePrior
Copy link

I like the pill design.

@mrhotio
Copy link

mrhotio commented Feb 14, 2021

Just letting you know that if the speed goed above 100MB/s the box goes like in the screenshot, I created the screenshot by using Inspect Element so the indicator for the speed is wrong, but I've seen it in real life.

Schermafbeelding 2021-02-14 om 12 40 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea Nor Bug nor feature, but a suggestion or Idea. Can be moved to discussions?
Projects
None yet
Development

No branches or pull requests

4 participants