Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the acceptance-test stage scripts #611

Open
yongja79 opened this issue Jan 31, 2024 · 0 comments
Open

Refactor the acceptance-test stage scripts #611

yongja79 opened this issue Jan 31, 2024 · 0 comments

Comments

@yongja79
Copy link
Contributor

Currently acceptance-test-stage.sh scripts builds a container that calls either make test-pipeline-e2e or make kind-e2e-test setting various environment variables that then can be called within the container. These make files are in each of the 3 operator repos

make test-pipeline-e2e and make kind-e2e-test then call the e2e-ocp.sh and e2e-kind.sh scripts respectively passing in even more variables. These scripts are in the common operators repo.

We should call e2e-ocp.sh and e2e-kind.shdirectly bypassing make as its unnecessary.

At the same time some cleanup of what variables are used can be done as several are passed in that are no longer used (docker variables for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants