Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate and address review comments from Docker Hub regarding label/env #529

Open
leochr opened this issue Jul 27, 2023 · 0 comments
Open
Assignees

Comments

@leochr
Copy link
Member

leochr commented Jul 27, 2023

docker-library/official-images#14955 (comment):

LABEL, ENV should be defined at late as possible so that their changing wouldn't break unnecessary build cache. Related is the location of the RUN that installs dumb-init, it should be before the LABEL and ENV declarations to maximize the cache efficiency of the Dockerfile (i.e. installed packages/binaries that don't change because of a Open/WebSphere-liberty version bump should be defined in layers before any version-related ENV or LABEL). I believe that there are already versions that have the dumb-init install line later than the liberty version variables, so this is instead something to be considered instead of blocking this PR, but may be included if you like.

@leochr leochr changed the title Evaluate review comments from Docker Hub regarding label/env Evaluate and address review comments from Docker Hub regarding label/env Jul 27, 2023
@kabicin kabicin self-assigned this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants