Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply license option should be moved to configure.sh for the customers #258

Open
jagraj opened this issue May 3, 2019 · 2 comments
Open
Labels

Comments

@jagraj
Copy link

jagraj commented May 3, 2019

While building docker images users have to add following code to apply the license. It makes sense to move this to configure.sh and users does not have to do this in their docker files.

# Upgrade to production license if URL to JAR provided
ARG LICENSE_JAR_URL
RUN \ 
  if [ $LICENSE_JAR_URL ]; then \
    wget $LICENSE_JAR_URL -O /tmp/license.jar \
    && java -jar /tmp/license.jar -acceptLicense /opt/ibm \
    && rm /tmp/license.jar; \
  fi
@imv7
Copy link

imv7 commented May 4, 2019

What is the image's name?

@hsaunders0788
Copy link

Is there a reason this might not have been put in the configure.sh in the first place? Perhaps they are kept separate on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants