Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAS_VAE_Input_Switch.vae_switch() got an unexpected keyword argument 'boolean_number' #364

Open
adrian-forest opened this issue Mar 15, 2024 · 8 comments

Comments

@adrian-forest
Copy link

Error from VAE Input Switch:

`Error occurred when executing VAE Input Switch:

WAS_VAE_Input_Switch.vae_switch() got an unexpected keyword argument 'boolean_number'

File "E:\stable\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "E:\stable\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "E:\stable\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))`

@adrian-forest
Copy link
Author

A probably very bad workaround? #365

@wandrzej
Copy link

the latest update seems to have messed up the variable types in switches - I had workflows that used NUMBER as input, and now it seems it's not going to work anymore.
Wonder what's the plan for those switch nodes?

@Ionaut
Copy link

Ionaut commented Mar 27, 2024

Check these in custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py
image

@nachocheeseburger
Copy link

Check these in custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py image

sorry for being noob but what do we change here?

@Pos13
Copy link

Pos13 commented Apr 1, 2024

Check these in custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py

That breaks sharing your workflow with others. It's such a minor fix, I hope it will be implemented soon.

@adrian-forest
Copy link
Author

It's been almost a month since the last commit, and I don't love the idea of people using my janky hack code as a workaround, so hopefully this can get some attention soon!

@Pos13
Copy link

Pos13 commented Apr 7, 2024

Speaking of jank hacks: as a temorary workaround, you can cast number to text and compare it to "1" to get a BOOLEAN.
image

@WAS-PlaiLabs
Copy link
Collaborator

image

7fb0766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants