Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something about search #306

Closed
ted423 opened this issue Oct 6, 2021 · 4 comments
Closed

Something about search #306

ted423 opened this issue Oct 6, 2021 · 4 comments

Comments

@ted423
Copy link

ted423 commented Oct 6, 2021

Readed #250

as a torrent named Key and Peele S03 1080p BluRay REMUX AVC TrueHD.5.1-EPSiLON
but the group name “EPSiLON” is on the last but can't be searched

@IevgenSobko
Copy link
Contributor

IevgenSobko commented Nov 1, 2021

@ted423 That is great that you found our initial discussion about filtering. And I think you already got why you can't find expected torrent.
I thought noone needs matches which starting at position past 25.
We use fuse.js with threshold 0.25 which means with default distance value of 100 it will search for matches which starting position is only in first 100*0.25=25 letters.
https://github.com/WDaan/VueTorrent/blob/master/src/views/Dashboard.vue#L247

@WDaan we tuned this property last time by my request because I had too much matches.
How about we stop using fuse.js because I actually have severe performance issue with it.
My torrent list is under 500 torrents and I am getting some response from UI(on type text) only after about 3-5 seconds(depends on devices). Also see MacBook gets very hot very fast if I leave VueTorrent tab opened with some filter. This issue is even worse on mobile devices(phone, tablet).

@WDaan
Copy link
Collaborator

WDaan commented Nov 1, 2021

I'm open to alternatives. It's what we've been using at work & one of the better libraries I know. Feel free to leave recommendations. I don't think implementing custom logic ourselves would be efficient.

@ted423
Copy link
Author

ted423 commented Mar 14, 2022

At present, I have 950 torrents, and the search will be obviously stuck
But in using this webui will not
https://github.com/CzBiX/qb-web

However, I do not know the specific implementation and if it has some problem

@IevgenSobko
Copy link
Contributor

@WDaan lets switch to complete match instead fuzzy for next release.
It should dramatically increase performance as well as increase position of match in a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants