Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection not cleared when moving torrent to a different category #1623

Open
3 tasks done
maxiwheat opened this issue Mar 29, 2024 · 2 comments
Open
3 tasks done

Selection not cleared when moving torrent to a different category #1623

maxiwheat opened this issue Mar 29, 2024 · 2 comments
Labels
Bug Something isn't working Dashboard

Comments

@maxiwheat
Copy link

Bug description

If I'm a in a list of torrents with a filter on a single category (or Uncategorized) and I select a few torrents and then with the context menu I select Set Category -> Another Category, my torrents get moved to a new category, which does not fit the filter I previously set. The torrents disappear from the view, but they remain selected, which I found misleading since I don't see them anymore. Moreover, if I keep selecting other torrents they are added to the selection.

Selection (notice the torrent count in the upper right):
image

After moving them to a different category:
image

Expectations

The selection should be cleared from the torrents that don't fit the filter anymore.

Relevant debug informations

No response

Steps to reproduce

  1. ...
  2. ...
    ...

How did you install VueTorrent?

Downloaded from GitHub releases

Environment description

Device type and name: 
OS: Docker in Unraid

PWA: ?
Running inside a container: Yes

qBittorrent version

4.6.3

VueTorrent version

2.7.2

Agreements

  • The bug still occurs on the nightly build
  • The bug still occurs on the latest version of qBittorrent
  • A similar issue doesn't already exist
@maxiwheat maxiwheat added Bug Something isn't working triage Issue hasn't been assessed yet labels Mar 29, 2024
@Larsluph Larsluph added Dashboard and removed triage Issue hasn't been assessed yet labels Mar 30, 2024
@Larsluph
Copy link
Collaborator

The selection should be cleared from the torrents that don't fit the filter anymore.

Not sure if that should be the way to go. Let's say you want to change category of several torrents by searching them with their name, it will become impossible if we follow your idea.

I think filtering after an action (changing tag / category) would be better UX-wise.

@maxiwheat
Copy link
Author

The selection should be cleared from the torrents that don't fit the filter anymore.

Not sure if that should be the way to go. Let's say you want to change category of several torrents by searching them with their name, it will become impossible if we follow your idea.

I think filtering after an action (changing tag / category) would be better UX-wise.

That makes sense, but you would need to re-pop de selection tool to continue selecting more torrents.

My typical use case (which lead me to create this issue):

  1. My filter is set by default to "Uncategorized"
  2. That filter returns 12 torrents
  3. I pop the selection tool, the checkboxes appear
  4. I select 5 torrents among the 12 returned
  5. I set their category to Cat1
  6. Now I've got 7 torrents I can see in Uncategorized, the selection checkboxes are still displayed
  7. I select 3 torrents among the 7 remaining (thinking that the 5 I moved previously aren't selected anymore since I can't see them)
  8. I set their category to Cat2
  9. Now my 5 first torrents + 3 torrents are in Cat2 without noticing it

Also, this leads to strange results in selection numbers (in this case I was moving the only 2 torrents in Uncategorized to a specific category):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Dashboard
Projects
None yet
Development

No branches or pull requests

2 participants