Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: login / password autocomplete are no longer triggered #1504

Open
3 tasks done
fabiencharrasse opened this issue Feb 5, 2024 · 15 comments · Fixed by #1507
Open
3 tasks done

[Bug]: login / password autocomplete are no longer triggered #1504

fabiencharrasse opened this issue Feb 5, 2024 · 15 comments · Fixed by #1507
Labels
Accessibility Bug Something isn't working help wanted Extra attention is needed

Comments

@fabiencharrasse
Copy link

fabiencharrasse commented Feb 5, 2024

Bug description

I use Bitwarden as my password manager and since some times (weeks, months maybe, don't remember), the login and password are not autocompleted on login page using auto fill on page load : https://bitwarden.com/help/auto-fill-browser/#on-page-load

Expectations

Login and password should be autocompleted

Relevant debug informations

No response

How did you install VueTorrent?

Using a third-party docker image (hotio or others)

Environment description

https://github.com/arafatamim/linuxserver-io-mod-vuetorrent

qBittorrent version

4.6.3

VueTorrent version

2.6.0

Agreements

  • The bug still occurs on the nightly build
  • The bug still occurs on the latest version of qBittorrent
  • A similar issue doesn't already exist
@fabiencharrasse fabiencharrasse added Bug Something isn't working triage Issue hasn't been assessed yet labels Feb 5, 2024
@Larsluph
Copy link
Collaborator

Larsluph commented Feb 5, 2024

Are you sure it's not working? 😅

Screenshot_20240205_171521_Chrome.png

Is it working elsewhere?

@fabiencharrasse
Copy link
Author

Sorry my first message lake of precisions. I speak about the auto fill on page load : https://bitwarden.com/help/auto-fill-browser/#on-page-load
The inline auto fill work but i don't use it.

@Larsluph
Copy link
Collaborator

Larsluph commented Feb 6, 2024

I just checked and I can't find any docs on how to make it work.

Looks like they added a new feature called linked custom fields which forces it. I tested and I just pushed a fix to make them work

@fabiencharrasse
Copy link
Author

I just tested the change, ids are defined on both fields but no auto-complete :/

@Larsluph
Copy link
Collaborator

I just tested the change, ids are defined on both fields but no auto-complete :/

Yes I said that I found no way to make it work. You have to use linked fields

@fabiencharrasse
Copy link
Author

Sorry I read it wrong. I just tested, the autofill is rather long (3 seconds) and does not fill the password field. Was the password field filling up during your tests?

@Larsluph
Copy link
Collaborator

Sorry I read it wrong. I just tested, the autofill is rather long (3 seconds) and does not fill the password field. Was the password field filling up during your tests?

On page load it doesn't autofill but using any kind of manual autofill method works (the extension icon and the dropdown under the field)

@fabiencharrasse
Copy link
Author

Yes, my bug report concerns auto completion on page loading only. I tested saving the page (html) and doing auto completion tests when the page loads on the generated html file, and it works as expected. I think the problem comes from the fact that the HTML of the login page is modified when the page loads and therefore Bitwarden cannot fill the fields because they are modified at the same time as it detects them.

@Larsluph
Copy link
Collaborator

I already tested and autofill on loading works if you add linked fields.

@soredake
Copy link

Yes, my bug report concerns auto completion on page loading only.

Seems I'm having the same problem, but with keepassxc-browser addon.

@fabiencharrasse
Copy link
Author

I already tested and autofill on loading works if you add linked fields.

Did i miss something ? I tried using password as text field and linked field type (user / password) too. No success.

image

@Larsluph
Copy link
Collaborator

I don't think you're using linked fields correctly, it should look like that:

image

@fabiencharrasse
Copy link
Author

I tried using password as text field and linked field type (user / password) too

I tried all the options offered by bitwarden, including this one :

image

@Larsluph
Copy link
Collaborator

Looking at the source, they use the DOMContentLoaded event with a 500ms delay to autofill, when trying to reproduce I got only the username autofilling. Weird behaviour as both field should be added at the same time in the DOM...

@Larsluph Larsluph reopened this Feb 17, 2024
@Larsluph Larsluph added help wanted Extra attention is needed Accessibility and removed triage Issue hasn't been assessed yet labels Feb 17, 2024
@fabiencharrasse
Copy link
Author

This seems to be a common issue on Bitwarden's side: bitwarden/clients#1621
I can't seem to find a guide to help make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants