Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding language settings #1403

Open
wushuo894 opened this issue Dec 10, 2023 · 4 comments
Open

Regarding language settings #1403

wushuo894 opened this issue Dec 10, 2023 · 4 comments
Labels
good first issue Good for newcomers Improvement Something that should be improved.

Comments

@wushuo894
Copy link

I have discovered that language settings are stored in the local storage. In fact, the "locale" field can be obtained through the "/api/v2/app/preferences" endpoint. Thank you very much for your project!

@Larsluph Larsluph added good first issue Good for newcomers Improvement Something that should be improved. labels Dec 12, 2023
@WDaan
Copy link
Collaborator

WDaan commented Dec 17, 2023

What would be the benefit? As you only set this once?

@Larsluph
Copy link
Collaborator

Larsluph commented Dec 17, 2023

This originally was added to the API to localize the default WebUI. We could use that to store the locale on VueTorrent as it's just a string in the backend. We just need to check that it doesn't break qBit in some unexpected ways.

What would be the benefit? As you only set this once?

I think it's to prevent having to set it on multiple browsers, to act as a server default instead of client default.

@WDaan
Copy link
Collaborator

WDaan commented Dec 18, 2023

I think it's to prevent having to set it on multiple browsers, to act as a server default instead of client default.

That is indeed a good reason. But we need to make sure that we way we store the language is compatible with theirs.

@Kaowain
Copy link
Contributor

Kaowain commented Dec 31, 2023

it look like both are using localization as like 'en_US' , 'fr_FR' as key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Improvement Something that should be improved.
Projects
None yet
Development

No branches or pull requests

4 participants