Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGINT gracefully #4540

Open
jackgerrits opened this issue Mar 30, 2023 · 0 comments
Open

Handle SIGINT gracefully #4540

jackgerrits opened this issue Mar 30, 2023 · 0 comments
Labels
Feature Request New feature requested in system

Comments

@jackgerrits
Copy link
Member

Currently VW does not handle SIGINT gracefully, but just exits. It would be nice if it instead just stopped training at that example and immediately ran the finalization functions.

There is VW::details::set_done which is used to early exit when VW decided no more passes are needed. However, while this stops VW parsing further examples it does not stop VW from consuming any already parsed examples. Ideally, VW would also stop consuming examples. Therefore, if using VW::details::set_done for a SIGINT scenario there can still be a large delay while the rest of the pass is consumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature requested in system
Projects
None yet
Development

No branches or pull requests

1 participant