Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible regression from forgeflower with java 14 instanceof #360

Open
Machine-Maker opened this issue Apr 7, 2024 · 0 comments
Open

Possible regression from forgeflower with java 14 instanceof #360

Machine-Maker opened this issue Apr 7, 2024 · 0 comments
Labels
bug Something isn't working Priority: Low Low priority Subsystem: Variables Anything concerning variables, types, assignments, and casting

Comments

@Machine-Maker
Copy link

Vineflower version

1.11.0-20240406.040032-5

Describe the bug

On 2.0.627.2 of forgeflower, more instanceof+local var are created using Java 14's new instanceof syntax, but on the version of vineflower above, they revert back to just doing casts.

Additional information

From SculkShriekerBlockEntity.java in Minecraft

ForgeFlower

image

Vineflower

image

The reason the title says "possible" is that forgeflower might be adding extra local vars if one didn't exist in the bytecode whereas vineflower might just being as "correct" to the bytecode as possible, idk.
@Machine-Maker Machine-Maker added the bug Something isn't working label Apr 7, 2024
@jaskarth jaskarth added Priority: Low Low priority Subsystem: Variables Anything concerning variables, types, assignments, and casting labels Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Priority: Low Low priority Subsystem: Variables Anything concerning variables, types, assignments, and casting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Machine-Maker @jaskarth