Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow set encoding= in new files if a previous file used scriptencoding #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow set encoding= in new files if a previous file used scriptencoding #364

wants to merge 2 commits into from

Conversation

puremourning
Copy link

@puremourning puremourning commented May 19, 2020 •
edited

Fixes #363

Needs a test, but would appreciate feedback on the approach.

Manual testing (repro case) : PASS
tox -e py37: PASS

This change is Reviewable

@puremourning puremourning changed the title [WIP] Allow set encoding= in new files if a previous file used scriptencoding Allow set encoding= in new files if a previous file used scriptencoding Jan 9, 2021
@puremourning
Copy link
Author

I have been using this patch for months now for vimspector. Any reason it can't be merged ?

@puremourning puremourning mentioned this pull request Mar 12, 2022
Open
@puremourning
Copy link
Author

I guess this isn't wanted.

@blueyed
Copy link
Member

blueyed commented Oct 24, 2022

It's more like the repo lacks maintenance, let's reopen it for now.

@blueyed blueyed reopened this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious scriptencoding error when checking multiple files
2 participants
@puremourning @blueyed