Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some better questions :) #18

Merged
merged 8 commits into from Apr 6, 2020
Merged

added some better questions :) #18

merged 8 commits into from Apr 6, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2020

added some new question to questions_acronyms.py, questions_back_end.py, questions_front_end.py, questions_pop_culture.py, questions_version_control.py

icodegeekhere and others added 6 commits March 17, 2020 19:44
added some new question to questions_acronyms.py, questions_back_end.py, questions_front_end.py, questions_pop_culture.py, questions_version_control.py
@VickiLanger VickiLanger linked an issue Mar 17, 2020 that may be closed by this pull request
@@ -15,6 +15,9 @@
'In "Silicon Valley" Season 3 Episode 1, what language is being used?\n@SiliconHBO', # https://www.reddit.com/r/SiliconValleyHBO/comments/4gbra7/i_got_the_silicon_valley_s03e01_code_to_compile/)
'What day is celebrated as Programmer\'s day? Why?\n#ProgrammersDay', #
'🐠In Mr. Robot, what is the name of Elliot\'s betta fish? @whoismrrobot #MrRobot', # Qwerty
'Who was the first Disney Princess? @DisneyStudios' #Disney
'Who created Mickey Mouse? @DisneyStudios #Disney' #Disney #MickeyMouse
'Why is Hacktoberfest done only once in a year? @Hacktoberfest #Hacktoberfest2020'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great question. Remember to follow the example in issue #5

'question goes here',  # short answer goes here, add a link if it's not a short answer

And the below to keep in line with Python syntax

  • Each question should be in its own line
  • Surrounded by single quotes (')
  • Keep the trailing comma

@@ -15,6 +15,9 @@
'In "Silicon Valley" Season 3 Episode 1, what language is being used?\n@SiliconHBO', # https://www.reddit.com/r/SiliconValleyHBO/comments/4gbra7/i_got_the_silicon_valley_s03e01_code_to_compile/)
'What day is celebrated as Programmer\'s day? Why?\n#ProgrammersDay', #
'🐠In Mr. Robot, what is the name of Elliot\'s betta fish? @whoismrrobot #MrRobot', # Qwerty
'Who was the first Disney Princess? @DisneyStudios' #Disney
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fun question, but is it code-related?
Code Questions bot is meant to help developers learn code things together.

@@ -15,6 +15,9 @@
'In "Silicon Valley" Season 3 Episode 1, what language is being used?\n@SiliconHBO', # https://www.reddit.com/r/SiliconValleyHBO/comments/4gbra7/i_got_the_silicon_valley_s03e01_code_to_compile/)
'What day is celebrated as Programmer\'s day? Why?\n#ProgrammersDay', #
'🐠In Mr. Robot, what is the name of Elliot\'s betta fish? @whoismrrobot #MrRobot', # Qwerty
'Who was the first Disney Princess? @DisneyStudios' #Disney
'Who created Mickey Mouse? @DisneyStudios #Disney' #Disney #MickeyMouse
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fun question, but is it code-related?

Copy link
Owner

@VickiLanger VickiLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great questions! Thanks for adding them. If you wouldn't mind, please address the comments I left.

Also, I'd like to add you to the Contributors list. Do. you have a Twitter handle you'd like me to include?

@ghost
Copy link
Author

ghost commented Apr 6, 2020 via email

Copy link
Owner

@VickiLanger VickiLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All adjustments made. Ready to merga

@VickiLanger VickiLanger merged commit c6b2ec5 into VickiLanger:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add questions to questions files in questions_dir
2 participants