Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate module_name and automatically perform extraction for all available modules? #89

Open
LukasMut opened this issue Oct 9, 2022 · 5 comments
Assignees
Labels
cleanup Deprecate or refactor code question Further information is requested

Comments

@LukasMut
Copy link
Collaborator

LukasMut commented Oct 9, 2022

No description provided.

@LukasMut LukasMut added question Further information is requested cleanup Deprecate or refactor code labels Oct 9, 2022
@LukasMut LukasMut changed the title Deprecate model_name and perform extraction for all available modules? Deprecate model_name and automatically perform extraction for all available modules? Oct 9, 2022
@LukasMut LukasMut changed the title Deprecate model_name and automatically perform extraction for all available modules? Deprecate module_name and automatically perform extraction for all available modules? Oct 9, 2022
@andropar
Copy link
Collaborator

Suggestion: Let user provide either None for all modules, str for single module or List for multiple modules. This should also probably come after #74.

@LukasMut
Copy link
Collaborator Author

This sounds reasonable. We should probably only accept None or List[str]. For a single module, the list contains only a single element.

@LukasMut
Copy link
Collaborator Author

For this, we want to use defaultdict(list) from collections and append features for every module.

@PhilippKaniuth
Copy link
Member

I second letting users provide names. Otherwise, some users might be suprised/confused how much of their storage - depending on the network they chose - is now filled with activations for dozens of modules :)

I'm not sure if I'd go with None for all modules though. It might be more intuitive to require the string all. But I can't evaluate whether that makes things ugly or harder to maintain code-wise :) Just my 2 cents.

@andropar
Copy link
Collaborator

andropar commented Oct 27, 2022

I think making extracting all modules more explicit makes sense, otherwise you could just do it by accident. Maybe the best option would be to only allow List[str] and if the user really wants to extract everything, he could just do module_names=extractor.get_modules_names()? I think that's an edge case anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Deprecate or refactor code question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants