You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LukasMut
changed the title
Deprecate model_name and perform extraction for all available modules?
Deprecate model_name and automatically perform extraction for all available modules?
Oct 9, 2022
LukasMut
changed the title
Deprecate model_name and automatically perform extraction for all available modules?
Deprecate module_name and automatically perform extraction for all available modules?
Oct 9, 2022
Suggestion: Let user provide either None for all modules, str for single module or List for multiple modules. This should also probably come after #74.
I second letting users provide names. Otherwise, some users might be suprised/confused how much of their storage - depending on the network they chose - is now filled with activations for dozens of modules :)
I'm not sure if I'd go with None for all modules though. It might be more intuitive to require the string all. But I can't evaluate whether that makes things ugly or harder to maintain code-wise :) Just my 2 cents.
I think making extracting all modules more explicit makes sense, otherwise you could just do it by accident. Maybe the best option would be to only allow List[str] and if the user really wants to extract everything, he could just do module_names=extractor.get_modules_names()? I think that's an edge case anyway
No description provided.
The text was updated successfully, but these errors were encountered: