Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xed #4202

Closed
xusheng6 opened this issue Apr 8, 2023 · 6 comments
Closed

Update xed #4202

xusheng6 opened this issue Apr 8, 2023 · 6 comments
Assignees
Labels
Arch: x86 Issues with the x86/x64 architecture plugin Component: Architecture Issue needs changes to an architecture plugin Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality

Comments

@xusheng6
Copy link
Member

xusheng6 commented Apr 8, 2023

It has been a while since we last updated the xed build, and now we are bothered by some xed bugs:

  1. "push r16" not correctly lifted in x86 (32 bits) #4028
  2. Intrinsics for IN and OUT take rflags as an argument #4033
  3. Disassembly of vbroadcastsd memory access is incorrect #4617

We should check and see if these are fixed in the latest xed build. If not, we should report them upstream

@plafosse plafosse added the Type: Enhancement Issue is a small enhancement to existing functionality label Apr 10, 2023
@plafosse plafosse added this to the Coruscant milestone Apr 10, 2023
@plafosse plafosse added Impact: Medium Issue is impactful with a bad, or no, workaround Arch: x86 Issues with the x86/x64 architecture plugin Component: Architecture Issue needs changes to an architecture plugin labels Apr 10, 2023
@xusheng6 xusheng6 added the Effort: Low Issue should take < 1 week label May 11, 2023
@plafosse plafosse modified the milestones: Coruscant, Dorsai Aug 1, 2023
@xusheng6
Copy link
Member Author

I tested the latest xed and none of the three issues are fixed. I feel like we should upstream these bugs and ask xed folks to fix them so that we can benefit from it.

Also, one aspect that is making xed complicated is that we need to generate these type info for the intrinsics: https://github.com/Vector35/arch-x86/blob/master/x86_intrinsic_cached_input_types.include. I left comment in https://github.com/Vector35/arch-x86/tree/master/code_generator so I do not need to re-invent the wheels, but it is taking me some time to actually get the patch working again, on top of the latest xed. If possible, I would also love to see a way to dump these types in a more straightforward way.

@xusheng6
Copy link
Member Author

Update on these:

1 is believed to be a bug in xed, and I have created an issue for it: intelxed/xed#319
2 is the intended behavior (though slightly less than desired), and I have closed it
3 is still being worked on, and I have ruled out the possibility of a xed bug. And it is probably due to some problems in our xed build process. So updateing xed would not help this.

In other words, updating xed itself would not help any these problems right now, so I am giving this issue a lower priority

@xusheng6
Copy link
Member Author

xusheng6 commented Jan 30, 2024

I would like to defer the xed update until intelxed/xed#319 is fixed -- which makes sense because otherwise the update does not bring about any known improvements to the x86 support. I kinda expect the xed folks will be able to fix it relatively soon, so the wait would not be too long

@plafosse plafosse modified the milestones: Dorsai, Elysium Feb 8, 2024
@xusheng6
Copy link
Member Author

xusheng6 commented Apr 4, 2024

Xed released intelxed/xed@6d87b54 which fixes the "push r16" bug above

@xusheng6
Copy link
Member Author

I have update xed to v2024.04.01.

But I am caught by surprise that intelxed/xed#319 is indeed NOT fixed. I confused it with intelxed/xed#320, which actually gets fixed. Chances are I will need to update xed again soon to involve the bug fix for intelxed/xed#319

@xusheng6 xusheng6 removed this from the Elysium milestone May 2, 2024
@xusheng6
Copy link
Member Author

xusheng6 commented May 2, 2024

I am closing this now since the only issue left within it is #4028

@xusheng6 xusheng6 closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: x86 Issues with the x86/x64 architecture plugin Component: Architecture Issue needs changes to an architecture plugin Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants