Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in Vc that arise when compiling ROOT #355

Open
guitargeek opened this issue Jun 12, 2023 · 5 comments
Open

Fix warnings in Vc that arise when compiling ROOT #355

guitargeek opened this issue Jun 12, 2023 · 5 comments

Comments

@guitargeek
Copy link

When including Vc.h, ROOT Math disables several compiler diagnostics to avoid warnings in the CI and nightlies:
https://github.com/root-project/root/blob/0fd27057b7b25e777ea642dfcc216ab27a6ece0d/math/mathcore/inc/Math/Types.h

It would be good if any warnings can be avoided in upstream veccore, such that we don't need this hack in ROOT.

See also root-project/veccore#24.

@bernhardmgruber
Copy link
Collaborator

Hi! Vc is no longer developed. If you can provide a PR, I can help you get it in. In the long term I would try to migrate to std::simd. There is a fallback implementation available if you have to support compilers without std::simd: https://github.com/mattkretz/vir-simd

@dpiparo
Copy link
Contributor

dpiparo commented Sep 24, 2023

for the time being: #356 . If you are happy with the pr, your test suite and nightlies pass, could you tag a new version so that it can be included e.g. in ROOT? Thanks a lot in advance!!

@bernhardmgruber
Copy link
Collaborator

I merged the PR on Vc.

@bernhardmgruber
Copy link
Collaborator

@guitargeek, does PR #356 entirely solve this issue?

@guitargeek
Copy link
Author

No, not entirely. It solves the current remaining warning in the nighlies, yes, but we have still "hotfixed" away several warnings in ROOT Math:
https://github.com/guitargeek/root/blob/master/math/mathcore/inc/Math/Types.h#L11

Once Vc is in a state where we get no warnings in the ROOT nightlies without the pragmas, then I would consider this issue as solved.

Thanks for the work you have done already, @bernhardmgruber and @dpiparo 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants