Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dandelifeon cells at the boundary #4353

Closed
biblically-approximate-arda opened this issue May 1, 2023 · 1 comment · Fixed by #4648
Closed

Dandelifeon cells at the boundary #4353

biblically-approximate-arda opened this issue May 1, 2023 · 1 comment · Fixed by #4648
Assignees
@Alwinfy

Comments

@biblically-approximate-arda
Copy link

Mod Loader

Forge

Minecraft Version

1.19.2

Botania version

1.19.2-438

Modloader version

1.19.2 Forge 43.2.8

Modpack info

Create Flavoured, with Botania and Immersive Engineering (1.19.2-9.2.-164) added in. Create Flavoured is https://www.curseforge.com/minecraft/modpacks/create-flavored

The latest.log file

https://pastebin.com/kbmvw5dS

Issue description

Dandelifeons consider cell blocks outside the range of any dandelifeon, active or otherwise, each step. Cells just outside the range of the flower can therefore create cells in range without themselves being able to die, allowing trivial setups like straight lines of 27 cells just out of range to produce ludicrous mana.

This is behaviour is consistent in singleplayer and multiplayer on the modpack I play on, and I'm told the issue is known by developers.

Steps to reproduce

  1. Dandelifeon
  2. Cells just out of range
  3. Watch'em go

Other information

I'm StoneColourSkies#7224 on Discord, and I'm in the Violet Moon server. Feel free to ping or DM if I've missed something.
@yezhiyi9670
Copy link

Can confirm for 1.20.1-443-FORGE. I can reproduce it with just Botania and its required dependencies.

The 1.12.2 and 1.18.2 versions of Botania do not have this issue. I think it is possibly due to the 1.19 change which allows several Dandelifeons to have overlapping working regions as long as they do not work at the same time.

Game screenshot

Game screenshot

Demonstration

@NEstoll NEstoll mentioned this issue May 16, 2024
Merged
TheRealWormbo pushed a commit that referenced this issue May 25, 2024
@NEstoll
Dandelifeon border cell exploit fix (#4648)
ee77979 
Fixing the "exploit" by requiring cells to have a powered parent in order to qualify as a boundary cell. (fixes #4353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alwinfy Alwinfy

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dandelifeon exploit fix NEstoll/Botania
3 participants
@Alwinfy @yezhiyi9670 @biblically-approximate-arda