Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ender Air Bottling Interaction blocks bottle block interactions in the End #4273

Open
DaFuqs opened this issue Jan 23, 2023 · 1 comment · May be fixed by #4392
Open

Ender Air Bottling Interaction blocks bottle block interactions in the End #4273

DaFuqs opened this issue Jan 23, 2023 · 1 comment · May be fixed by #4392

Comments

@DaFuqs
Copy link

DaFuqs commented Jan 23, 2023 •
edited

Mod Loader

Fabric

Minecraft Version

1.19.2

Botania version

1.19.2-436

Modloader version

Any

Modpack info

No response

The latest.log file

Issue description

The ender air bottling logic is implemented via UseItemCallback.EVENT.register(EnderAirItem::onPlayerInteract);. It returns sucess() if the player is in the End and no dragon breath would be picked up.

Returning pass at this stage will skip any bottle on block interaction, since the interaction has already been handled, preventing players to interact with blocks using a bottle in the end (like bottling fluids).

A suggested fix would be to only collect Ender Air is the player is not targeting a block, while otherwise calling pass().

Steps to reproduce

  1. Go to the End
  2. Right Click with a bottle anywhere that is not near dragon's breath (in the air, on water, on stone, ...)
  3. You get Ender Air

Other information

No response
@TheRealWormbo
Copy link
Collaborator

Issue also exists on Forge. However, on both platforms it only applies to bottling water. Interaction with e.g. bee hives works fine since that's a separate event that fires before Botania's ender air pickup attempt.
Might be a relatively simple fix by also checking whether the player targets a fluid.

@TheRealWormbo TheRealWormbo mentioned this issue Apr 13, 2023
Merged
unilock added a commit to unilock/Botania that referenced this issue Jun 1, 2023
@unilock
Only create Ender Air Bottles when aiming at nothing (HitResult.Type.…
9118584 
…MISS)

Some mods add features that rely on using empty Glass Bottles on *blocks*, not just fluids.
This commit allows that to happen by only creating Ender Air Bottles when the player is aiming at *nothing* - not a block *or* a fluid (instead of only checking for fluids)

Fixes VazkiiMods#4273

Signed-off-by: unilock <unilock@fennet.rentals>
@unilock unilock linked a pull request Jun 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only create Ender Air Bottles when aiming at nothing unilock/Botania
2 participants
@TheRealWormbo @DaFuqs