Add parameterless constructor to morph message #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alwinfy let me know if there's anything I need to change before this gets merged. |
|
[edit: removed snarkyness] I think I can do better, so I'm going to go make my own mod. With blackjack and hookers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
From the error message posted in that issue I traced the error to
vazkii.arl.network.NetworkHandler, which expects all messages to have a constructor with no parameters.MessageMorphTomeimplements a single constructor which takes a parameter. As a result,NetworkHandlererrors out whenever it tries to deserialize the morph message, preventing the Tome from morphing into any of the books it contains.I fixed this by making adding a parameterless constructor to
MessageMorphTomeand removingstaticfrommodid. I didn't touch the existing constructor, so this shouldn't break anything else.I've tested this locally on my client with no issues.