SteamVR alloc 1.7k on a background thread

[AndersMalmgren]

I tried with SteamVR disabled and only use OpenXR. That does not allocate anything. I then try SteamVR and then it allocates 1.7kb in a background thread

You need to test this with a built player otherwise the editor keeps polluting the profiler

[AndersMalmgren]

I have found the culprit. Package com.valvesoftware.unity.openvr in file OpenVRLoader.cs uses a System.IO.FileSystemWatcher to detect somekind of changes to some mirror cfg something, something. System.IO.FileSystemWatcher seems to allocate under Mono.

[zite]

Thanks for looking into this, Anders. I believe that watcher should be disabled for builds

[AndersMalmgren]

Thanks for looking into this, Anders. I believe that watcher should be disabled for builds

Hi. It's enabled for builds at least the version included in latest steamvr plugin.

[AndersMalmgren]

Hi again @zite I just checked, code in master is identical to the one from latest unity plugin

https://github.com/ValveSoftware/unity-xr-plugin/blob/c8160441e8347769763f5803a56ec71898a720f0/com.valve.openvr/Runtime/OpenVRLoader.cs#L292

[AndersMalmgren]

Also this method allocates when joystick is being used

    private static void UpdateActionSetsArray()
    {
        List<VRActiveActionSet_t> activeActionSetsList = new List<VRActiveActionSet_t>();

        SteamVR_Input_Sources[] sources = SteamVR_Input_Source.GetAllSources();

        for (int actionSetIndex = 0; actionSetIndex < SteamVR_Input.actionSets.Length; actionSetIndex++)
        {
            SteamVR_ActionSet set = SteamVR_Input.actionSets[actionSetIndex];

            for (int sourceIndex = 0; sourceIndex < sources.Length; sourceIndex++)
            {
                SteamVR_Input_Sources source = sources[sourceIndex];

                if (set.ReadRawSetActive(source))
                {
                    VRActiveActionSet_t activeSet = new VRActiveActionSet_t();
                    activeSet.ulActionSet = set.handle;
                    activeSet.nPriority = set.ReadRawSetPriority(source);
                    activeSet.ulRestrictedToDevice = SteamVR_Input_Source.GetHandle(source);

                    int insertionIndex = 0;
                    for (insertionIndex = 0; insertionIndex < activeActionSetsList.Count; insertionIndex++)
                    {
                        if (activeActionSetsList[insertionIndex].nPriority > activeSet.nPriority)
                            break;
                    }
                    activeActionSetsList.Insert(insertionIndex, activeSet);
                }
            }
        }

        changed = false;

        rawActiveActionSetArray = activeActionSetsList.ToArray();

        if (Application.isEditor || updateDebugTextInBuilds)
            UpdateDebugText();
    }

[zite]

Thanks, I've got this fixed in the beta branch and it'll go into the next release.