add tests for older windows versions and fix bcrypt detection #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
past-due
reviewed
Jul 30, 2023
|
I have also added tests for 32bit windows in another branch. I can add it here too, if you are interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #287
some explanation: it is possible there were mistakes in older versions of windows sdk, however, this does not manifest in your tests as you are using vcpkg, which actually forces selecting latest available sdk, however this was not the default until cmake 3.27.
either way, this version with try_compile works correctly without vcpkg even with the older windows sdk.
this PR also adds more tests, specifically for both OpenSSL and BCrypt on both windows 2019 and 2022.