Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPacketLobby / SPacketLobby classes could be organized further? #116

Open
valkyrienyanko opened this issue May 25, 2022 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@valkyrienyanko
Copy link
Collaborator

Issue

Guess work has to be done when creating new packets. You have to look inside CPacketLobby to ensure you're filling out all the appropriate properties. Perhaps a class should be created for each lobby packet opcode? How would this work?
image
image

Everything is mushed together. Lots of scrolling with mouse has to be done to get around where you want to be in this script.
image
image
image
image
image
and so on...

Scripts

CPacketLobby.cs
https://github.com/GodotModules/GodotModulesCSharp/blob/dev/Scripts/Netcode/Packets/CPacketLobby.cs

SPacketLobby.cs
https://github.com/GodotModules/GodotModulesCSharp/blob/dev/Scripts/Netcode/Packets/SPacketLobby.cs

@valkyrienyanko valkyrienyanko added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant