Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument 'ATrimValues: Boolean = False' to DUnitX.Attributes.TestCaseAttribute.Create #331

Open
Nashev opened this issue Jul 12, 2023 · 1 comment

Comments

@Nashev
Copy link

Nashev commented Jul 12, 2023

#191 very very annoying, it makes impossible to make test cases readable and comparable between each others.
Please add a possibility to add spaces into the argument's list between values!

Add an argument ATrimValues: Boolean = False to the constructor DUnitX.Attributes.TestCaseAttribute.Create.

For backward compatibility I suggest to make it off by default, so we will need write a , True for every single mention of [TestCase()] declaration, but it is the lesser of the evils.

@Nashev
Copy link
Author

Nashev commented Jul 12, 2023

Oops, I went to make PR, and discovered an ATrimValues argument already exists )))

I haven't seen it in a copy, provided with a Delphi 11 at "C:\Program Files (x86)\Embarcadero\Studio\22.0\source\DunitX\DUnitX.Attributes.pas"

So, are there any best practices or pitfalls on the way to replacing the files from the distribution with the latest version?

@Nashev Nashev changed the title Add argument 'ATrimSpaces: Boolean = False' to DUnitX.Attributes.TestCaseAttribute.Create Add argument 'ATrimValues: Boolean = False' to DUnitX.Attributes.TestCaseAttribute.Create Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant