Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong cursor orientation after adding multi-cursor selection #9000

Closed
musjj opened this issue Apr 23, 2024 · 1 comment · May be fixed by #9008
Closed

Wrong cursor orientation after adding multi-cursor selection #9000

musjj opened this issue Apr 23, 2024 · 1 comment · May be fixed by #9008

Comments

@musjj
Copy link

musjj commented Apr 23, 2024

Describe the bug
When using the editor.action.addSelectionTo{Next,Previous}FindMatch command, the direction/orientation of the selection is not taken into account.

So for example if you have selected the word foo, with the cursor on f, when you run addSelectionToNextFindMatch you will get a new selection with the cursor at o like this:

>|foo| # original selection

|foo|< # new selection

To Reproduce
settings.json

{
  "vim.visualModeKeyBindings": [
    {
      "before": ["g", "n"],
      "commands": ["editor.action.addSelectionToNextFindMatch"]
    },
    {
      "before": ["g", "N"],
      "commands": ["editor.action.addSelectionToPreviousFindMatch"]
    }
  ]
}

Expected behavior
I expect the orientation of the cursor to always match the original selection.

Environment (please complete the following information):

Extension version: 1.26.1
VS Code version: Code 1.88.1 (e170252f762678dec6ca2cc69aba1570769a5d39, 2024-04-10T17:34:12.840Z)
OS version: Linux x64 6.6.28

@musjj
Copy link
Author

musjj commented Apr 23, 2024

Never mind, this is just the native behavior :/

@musjj musjj closed this as completed Apr 23, 2024
musjj added a commit to musjj/Vim that referenced this issue Apr 28, 2024
musjj added a commit to musjj/Vim that referenced this issue Apr 28, 2024
HenryTSZ pushed a commit to HenryTSZ/NVim that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant