Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::format #1081

Closed
jcoupey opened this issue Apr 8, 2024 · 4 comments · Fixed by #1084
Closed

Use std::format #1081

jcoupey opened this issue Apr 8, 2024 · 4 comments · Fixed by #1084
Assignees
@SebMilardo
Labels
good first issue refactor
Milestone
v1.15.0

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Apr 8, 2024

We have a bunch of warnings in the sonarcloud report about using std::format. I did not address this earlier in #984 or #986 simply because the support was missing in compilers at that time.

I suspect newer versions of both gcc and clang would now be OK with the changes so we should dig into this once the CI compiler upgrade in #1080 is completed.
@jcoupey jcoupey added this to the v1.15.0 milestone Apr 8, 2024
@kkarbowiak
Copy link
Contributor

On one of my machines I am using gcc 13.2.1 and clang 16.0.6 and both seem to support std::format nicely, so the versions mentioned in #1080 should be fine.

@SebMilardo
Copy link
Contributor

SebMilardo commented Apr 10, 2024 •
edited

I would like to help with this one, could you assign this issue to me?

@jcoupey
Copy link
Collaborator Author

jcoupey commented Apr 10, 2024

@SebMilardo great, please feel free to open a PR. A good place to start is the sonarcloud report listing expected changes (see above link).

@SebMilardo SebMilardo mentioned this issue Apr 11, 2024
Merged
2 tasks
@jcoupey
Copy link
Collaborator Author

jcoupey commented May 23, 2024

Thanks @SebMilardo, this removed 76 sonarcloud warnings on "maintanability issues", and those parts of the code are now indeed easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebMilardo SebMilardo

Labels
good first issue refactor
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging a pull request may close this issue.

Refactor/use format SebMilardo/vroom
3 participants
@SebMilardo @jcoupey @kkarbowiak