Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5309 - Add GND and DEL Automatic Airport Selection functionality #5310

Merged
merged 38 commits into from May 12, 2024

Conversation

PLM1995
Copy link
Collaborator

@PLM1995 PLM1995 commented May 10, 2024

Fixes #5309

Summary of changes

Implemented for all GND and DEL positions defined in the UK sector file.

Screenshots (if necessary)

N/A

@PLM1995 PLM1995 added the enhancement For new or improved features label May 10, 2024
@luke11brown
Copy link
Contributor

luke11brown commented May 10, 2024

How does this affect the predicted sector for FIN controllers? I believe we need to define sectors for the ownership to work as well.

e.g. if GND & TWR online, does it show GND as the owner of the ATZ circle? If so, it'll show the wrong sector to the FIN controller.

Airports/EGAA/Ownership.txt Outdated Show resolved Hide resolved
@PLM1995
Copy link
Collaborator Author

PLM1995 commented May 10, 2024

How does this affect the predicted sector for FIN controllers?

With EGKK_APP and EGKK_GND on, no ATZ circle displayed, dep list populated, and SI blank:
image

With EGKK_APP, _TWR and _GND on, ATZ circle displayed, dep list depopulated, and SI reads KKT:
image

Which is I believe all as it was before/should be?


I believe we need to define sectors for the ownership to work as well.

What I have done seems to be enough to give the automatic airport ownership for GND and DEL.

Airports/EGQL/Ownership.txt Outdated Show resolved Hide resolved
Co-authored-by: Lee Roberts <42523604+Robbo599@users.noreply.github.com>
@PLM1995 PLM1995 merged commit f397cd7 into VATSIM-UK:main May 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For new or improved features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UK GND/DEL Positions Airport "Ownership" (for ARR/DEP APT Auto Select)
3 participants