Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5305 - Add Burnham Box #5304

Merged
merged 6 commits into from May 12, 2024
Merged

Fixes #5305 - Add Burnham Box #5304

merged 6 commits into from May 12, 2024

Conversation

KHardern
Copy link
Contributor

@KHardern KHardern commented May 5, 2024

Fixes #5303

Summary of changes

Adds the Burnham box to the Bristol STAR/RMA section

Screenshots (if necessary)

image

@KHardern
Copy link
Contributor Author

KHardern commented May 5, 2024

@PLM1995 Slightly debatable as to where to put this. It's relevant to both Bristol and Cardiff, so it could go in misc. But it only applies to Bristol inbounds... I think by naming it with "(Bristol)" at the end will make it easy to locate.

Thoughts?

@KHardern KHardern added the controller-pack-change A change to the controller pack is required label May 5, 2024
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PLM1995 Slightly debatable as to where to put this. It's relevant to both Bristol and Cardiff, so it could go in misc. But it only applies to Bristol inbounds... I think by naming it with "(Bristol)" at the end will make it easy to locate.

Thoughts?

Good question. We already have the Exmor Burnham Line defined in the Radar Map (Stars) folder (displays per below), and this feels very similar to that? Are you deliberately re-defining it, and if so I would probably update that file, maybe with a re-name, rather than adding it to the RMA one.

image

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@PLM1995 PLM1995 added the enhancement For new or improved features label May 6, 2024
@KHardern
Copy link
Contributor Author

KHardern commented May 7, 2024

I think the line is the exact same from the look of it, so let's put them together.

@KHardern
Copy link
Contributor Author

On a re-think.
So I think my Burnham box coordinates are more accurate than the line. I suggest we keep BOTH drawn (as both are referenced and to avoid people losing lines on controller pack profiles).

@KHardern
Copy link
Contributor Author

@PLM1995 check you're happy with the move

Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PLM1995 PLM1995 merged commit 58e3a58 into main May 12, 2024
3 checks passed
@PLM1995 PLM1995 deleted the issue-5303 branch May 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller-pack-change A change to the controller pack is required enhancement For new or improved features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Burnham Box (Bristol/Cardiff)
3 participants