Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5287 - Sectorisation: Airspace from S5 (BCN) -> S25 (LMS) [MERGE 1st] #5288

Open
wants to merge 6 commits into
base: issue-5285
Choose a base branch
from
Open

Fixes #5287 - Sectorisation: Airspace from S5 (BCN) -> S25 (LMS) [MERGE 1st] #5288

wants to merge 6 commits into from

Conversation

KHardern
Copy link
Contributor

Fixes #5287

Summary of changes

Airspace moved between S5 and S25

@PLM1995 As with the other change, provisional for 2406, but please seek confirmation from me.

@KHardern KHardern requested a review from hazzas-99 April 27, 2024 22:52
@PLM1995 PLM1995 added this to the 2406 milestone Apr 28, 2024
@PLM1995 PLM1995 added on-hold Pending scenery updates or an effective date procedure-change Non-AIP related procedure changes labels Apr 28, 2024
@hazzas-99
Copy link
Contributor

This will conflict after #5286 is merged. @PLM1995 if it's easiest, I can make this a PR into the issue-5285 branch, so this PR will need to be merged first, then the other into main? Both changes will be deployed at the same time, whenever that is!

@PLM1995
Copy link
Collaborator

PLM1995 commented May 1, 2024

This will conflict after #5286 is merged. @PLM1995 if it's easiest, I can make this a PR into the issue-5285 branch, so this PR will need to be merged first, then the other into main? Both changes will be deployed at the same time, whenever that is!

Sounds sensible to me.

@hazzas-99 hazzas-99 changed the title Airspace from S5 to S25 Fixes #5287 - Sectorisation: Xfer of airspace S5 (BCN) -> S25 (LMS) [MERGE 1st!!!] May 8, 2024
@hazzas-99 hazzas-99 changed the base branch from main to issue-5285 May 8, 2024 19:12
@hazzas-99 hazzas-99 changed the title Fixes #5287 - Sectorisation: Xfer of airspace S5 (BCN) -> S25 (LMS) [MERGE 1st!!!] Fixes #5287 - Sectorisation: Airspace from S5 (BCN) -> S25 (LMS) [MERGE 1st] May 8, 2024
PLM1995
PLM1995 reviewed May 10, 2024
View reviewed changes
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KHardern / @hazzas-99 Given this PR is now targetting the other issue branch (not main), I presume it can be merged whenever? Then that can be reviewed as a single unit and just hold off merging it until the target AIRAC? Or do you want to keep them both open for now?

Sectors/Lines - LTC.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand why some Sector DISPLAY lines like these get deleted and not replaced by something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PLM1995 PLM1995 PLM1995 left review comments

@hazzas-99 hazzas-99 hazzas-99 approved these changes

Assignees
No one assigned
Labels
on-hold Pending scenery updates or an effective date procedure-change Non-AIP related procedure changes
Projects
None yet
Milestone
2406
Development

Successfully merging this pull request may close these issues.

Transfer airspace in region of SAWPE from S5 to S25
3 participants
@KHardern @hazzas-99 @PLM1995