Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5273 - Re-structure/split 'Misc' folder #5274

Merged
merged 10 commits into from May 5, 2024

Conversation

PLM1995
Copy link
Collaborator

@PLM1995 PLM1995 commented Apr 15, 2024

Fixes #5273

Summary of changes

Separate new folders for:

  • Area Positions
  • Radar Maps (Stars)
  • Regions
  • Geo

Rest left in the Misc folder, now name "Misc Other"

compiler.config.json updated accordingly.

Please feel free to make suggestions as to other/better ways to do this if you have an idea, and hopefully nothing has changed in the compiler output!

@PLM1995 PLM1995 added the enhancement For new or improved features label Apr 15, 2024
@PLM1995 PLM1995 requested a review from hazzas-99 April 15, 2024 08:52
@PLM1995
Copy link
Collaborator Author

PLM1995 commented Apr 15, 2024

I know the wiki will need updating once we have an agreed structure.

Copy link
Contributor

@hazzas-99 hazzas-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good, apart from the Airspace 'STARs' name which I'm not entirely won over by. Perhaps Radar Maps (Stars) (lowercase Stars because that's how it appears in Display Settings)?

@PLM1995
Copy link
Collaborator Author

PLM1995 commented Apr 21, 2024

All look good, apart from the Airspace 'STARs' name which I'm not entirely won over by. Perhaps Radar Maps (Stars) (lowercase Stars because that's how it appears in Display Settings)?

Sounds good to me, adjusted.

Copy link
Contributor

@hazzas-99 hazzas-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems in order to me in the download!

@KHardern
Copy link
Contributor

KHardern commented May 4, 2024

Looks good to me

@PLM1995 PLM1995 merged commit 50c6274 into VATSIM-UK:main May 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For new or improved features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate the 'Misc' folder into more manageable 'silos'
3 participants