Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5253 - Update Manchester (EGCC) SMR #5254

Merged
merged 10 commits into from May 10, 2024
Merged

Fixes #5253 - Update Manchester (EGCC) SMR #5254

merged 10 commits into from May 10, 2024

Conversation

rishab-alt
Copy link
Collaborator

@rishab-alt rishab-alt commented Mar 26, 2024

Fixes #5253

Summary of changes

Amend construction area
reconfigure stands 69 - 74 (folder changed in KMZ)
added new stands 811 - 807 (these are not drawn but there when needed in the future )
rename E4 to E10

Screenshots (if necessary)

Before After
image image

ammend construction area
re configure stands 69 to 74 ( folder ammended )
added new stands through 811 to 807 ( these not drawn  but there when we need it )
rename E4 to E10
@rishab-alt rishab-alt added the airac AIP-related changes label Mar 26, 2024
@rishab-alt rishab-alt added this to the 2405 milestone Mar 26, 2024
@rishab-alt rishab-alt self-assigned this Mar 26, 2024
@rishab-alt
Copy link
Collaborator Author

Forgot the change log

@hazzas-99 hazzas-99 added the on-hold Pending scenery updates or an effective date label Mar 28, 2024
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mention, Changelog entry also required.

Thanks @rishab-alt

Airports/EGCC/SMR/Geo.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mention, Changelog entry also required.

Thanks @rishab-alt

_data/SMR Files/EGCC/EGCC.kmz Outdated Show resolved Hide resolved
@PLM1995 PLM1995 removed the on-hold Pending scenery updates or an effective date label Apr 18, 2024
@PLM1995
Copy link
Collaborator

PLM1995 commented May 5, 2024

@rishab-alt I notice you picked up another issue but still have pending review comments on this PR, are you able to make the requested alterations to the KMZ and add a changelog entry please?

@PLM1995
Copy link
Collaborator

PLM1995 commented May 9, 2024

@rishab-alt Given I have not had a response from you on this PR despite chasing twice, and we are now less than a week from it's deadline AIRAC, I will make these KMZ and Changelog corrections myself to allow time for review, merge and release.

It is over three weeks since these changes were requested, in which time you have done another 'good-first-issue' targeted for 2406. In future, please prioritise the open PRs which are due sooner, or at least communicate when you are likely to be able to respond to the comments/request changes.

Peter

- Change Stand 83 Centreline Colour
- Correct Folder Structure and Order
- Correct Stand Order within Folders
- Rename Folder for E Remote Stands
Remove unnecessary file (included in .kmz)
Airports/EGCC/SMR/Geo.txt Outdated Show resolved Hide resolved
@luke11brown luke11brown merged commit 989f8a8 into main May 10, 2024
3 checks passed
@luke11brown luke11brown deleted the issue-5253 branch May 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airac AIP-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Manchester (EGCC) Under Construction Area
4 participants