Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add algorithms and data structures in any language #163

Open
i-vishi opened this issue Oct 6, 2018 · 57 comments · May be fixed by #888, #1288, #1290, #1292 or #1295
Open

add algorithms and data structures in any language #163

i-vishi opened this issue Oct 6, 2018 · 57 comments · May be fixed by #888, #1288, #1290, #1292 or #1295
Labels
Algorithms Data Structures enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@i-vishi
Copy link
Member

i-vishi commented Oct 6, 2018

Dated: Oct-07-2020
Regarding Delay in reviewing PR
Hello, everyone, I am one of the maintainer of this repository. I know most of the PRs are the part of hacktoberfest and most of you are worried will your PRs will be eligible for Hacktoberfest 2020 or not. Since, all the maintainers are busy, it will take some time to review all the PRs. We have to review each PR and it may take some time.
Also, the rules of Hacktoberfest have been changed to reduce spam PRs. There are many SPAM PRs with invalid code or no code. So, we have to review each PR one by one. Due to the changes in rules, the burden has been shifted to maintainers.

About adding and then removing hacktoberfest-accepted label, it was just to check and verify the eligibility of the label. Do not consider it as making your PR invalid.

All the PRs will be checked and reviewed

Thanks and Happy coding 💻 👨‍💻 👩‍💻 💻

@i-vishi i-vishi added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest add algorithms to fix this issue Algorithms Data Structures labels Oct 6, 2018
@i-vishi
Copy link
Member Author

i-vishi commented Oct 6, 2018

Anyone can work on it. You only need to fork the repository and edit and then give a pull request. Just mention the issue in comment while giving Pull Request

@ananthuc73
Copy link
Contributor

Like to Add Bucket sorting algorithm in C++

@Santan47
Copy link
Contributor

added doubly LinkedList in c. #699

@i-vishi i-vishi removed the Hacktoberfest add algorithms to fix this issue label Dec 25, 2018
@i-vishi i-vishi added the Hacktoberfest add algorithms to fix this issue label Sep 30, 2019
@jatinpandey77 jatinpandey77 linked a pull request Oct 1, 2019 that will close this issue
@anmol20goyal
Copy link

I can provide the algorithm for singly and double linked list in c++ language @i-vishi

@i-vishi
Copy link
Member Author

i-vishi commented Oct 3, 2020

@pawan-git7979 we can not merge the pull request for the algorithms which have been already covered. If you find some error in the current implementation or want to add some explanation, then you can work on that algorithm.

@i-vishi
Copy link
Member Author

i-vishi commented Oct 3, 2020

@zahinekbal It is not required to add algorithms using STL. Any improvements in the current implementation can be appreciated.

@zahinekbal
Copy link
Contributor

@zahinekbal It is not required to add algorithms using STL. Any improvements in the current implementation can be appreciated.

Okk @i-vishi kindly check my graph problem & kadane's algorithm that I hv added nd please review my PR..
Thankyou

@ghost
Copy link

ghost commented Oct 3, 2020

#1259 @i-vishi why u r not merging it after seeing it also if their is a need of improvement then tell me na

@zahinekbal
Copy link
Contributor

#1259 @i-vishi why u r not merging it after seeing it also if their is a need of improvement then tell me na

Exactly same for me..

@zahinekbal
Copy link
Contributor

@zahinekbal It is not required to add algorithms using STL. Any improvements in the current implementation can be appreciated.

Okk @i-vishi kindly check my graph problem & kadane's algorithm that I hv added nd please review my PR..
Thankyou

Kindly check it @i-vishi I added graph problem & kadane's algorithm
Check it nd review my PR ..
If anything needed then please tell me.

@zahinekbal
Copy link
Contributor

@zahinekbal Sure, go ahead and implement. 👍

@i-vishi kindly check my code and review my PR..

@sameersrivastava13
Copy link
Contributor

sameersrivastava13 commented Oct 3, 2020

#1259 @i-vishi why u r not merging it after seeing it also if their is a need of improvement then tell me na

@HarshAgarwal-DEV @zahinekbal please read this you both will understand everything.

@sameersrivastava13
Copy link
Contributor

#1259 @i-vishi why u r not merging it after seeing it also if their is a need of improvement then tell me na

@HarshAgarwal-DEV @zahinekbal please read this you both will understand everything.

@sameersrivastava13 bro he that only he first added hactoberfest accepted label then removed it
so i want to know is my pr not eligible or i have to do some changes

@HarshAgarwal-DEV actually yes. Same for me also.
First he added the label then he removed it.

@Avispa666
Copy link

@i-vishi I also have some parallel sorting algorithms (mergesort, quicksort, etc.) which are done with MPI and OpenMP. It looks like nobody previously added them here. Can I add these algorithms?

@i-vishi
Copy link
Member Author

i-vishi commented Oct 7, 2020

@HarshAgarwal-DEV @zahinekbal @sameersrivastava13 See this comment

@zahinekbal
Copy link
Contributor

@HarshAgarwal-DEV @zahinekbal @sameersrivastava13 See this comment

Now can I Contribute in your issues ??

@UdeshAthukorala
Copy link

Hi, Can I Add Bucket Sorting algorithm in Python? @i-vishi Can you please assign this issue to me?

i-vishi added a commit that referenced this issue Oct 14, 2020
fixed #163 added program to find max element in ll
i-vishi added a commit that referenced this issue Oct 24, 2020
Solved #163 added  : partition list leet code
@i-vishi i-vishi reopened this Nov 3, 2020
@i-vishi i-vishi removed HacktoberFest2020 Hacktoberfest add algorithms to fix this issue labels Apr 14, 2021
@siya100
Copy link

siya100 commented Sep 16, 2023

can you please assign me this @i-vishi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment