From e6913a8496cc3cdf3806733c3dfceb701659e3e1 Mon Sep 17 00:00:00 2001 From: Mike Dawson Date: Sat, 6 Apr 2024 00:07:17 +0400 Subject: [PATCH] Update CompressVideoUseCaseJvmVlc to use h264/aac encoding. Based on command line testing of video output results. Issue #750 (desktop video compression) --- .../domain/compress/video/CompressVideoUseCaseJvmVlc.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/jvmMain/kotlin/com/ustadmobile/core/domain/compress/video/CompressVideoUseCaseJvmVlc.kt b/core/src/jvmMain/kotlin/com/ustadmobile/core/domain/compress/video/CompressVideoUseCaseJvmVlc.kt index 563fc6f10c..54ba54e9b7 100644 --- a/core/src/jvmMain/kotlin/com/ustadmobile/core/domain/compress/video/CompressVideoUseCaseJvmVlc.kt +++ b/core/src/jvmMain/kotlin/com/ustadmobile/core/domain/compress/video/CompressVideoUseCaseJvmVlc.kt @@ -47,9 +47,9 @@ class CompressVideoUseCaseJvmVlc( ): CompressResult? = withContext(Dispatchers.IO) { val fromFile = DoorUri.parse(fromUri).toFile() val destFile = if(toUri != null) { - DoorUri.parse(toUri).toFile().requireExtension("mpg") + DoorUri.parse(toUri).toFile().requireExtension("mp4") }else { - File.createTempFile(UUID.randomUUID().toString(), ".mpg") + File.createTempFile(UUID.randomUUID().toString(), ".mp4") } try { @@ -60,7 +60,7 @@ class CompressVideoUseCaseJvmVlc( val args = listOf( vlcPath, "-I", "dummy", "--no-repeat", "--no-loop", "-vv", fromFile.absolutePath, - "--sout=#transcode{vcodec=mp4v,acodec=mpga,vb=800,ab=128,deinterlace}:standard{access=file,mux=ps,dst=${destFile.absolutePath}}", + "--sout=#transcode{vcodec=h264,acodec=mp4a,vb=800,ab=128,deinterlace}:standard{access=file,mux=mp4,dst=${destFile.absolutePath}}", "vlc://quit" ) println(args.joinToString(separator = " "))