Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using regex from config to parse account list if available #981

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Using regex from config to parse account list if available #981

merged 1 commit into from
Apr 3, 2023

Conversation

davkutalek
Copy link
Member

@davkutalek davkutalek commented Mar 3, 2023 •
edited

Update SDK which has select by text parsing fixes as well

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Fixes #969 #962 probably a bunch of others that involve balance checks on multi-account USSD, especially KCB and COOP🦕

@davkutalek
Using regex from config to parse account list if available. Update SD…
7825a36 
…K which has select by text parsing fixes as well
@jumaallan jumaallan added this pull request to the merge queue Apr 3, 2023
Merged via the queue into main with commit 30552fc Apr 3, 2023
@jumaallan jumaallan deleted the parse-accounts-bugfix branch April 3, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumaallan jumaallan jumaallan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Check balance fails when checking bank account balance using KCB
2 participants
@davkutalek @jumaallan