Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup android editable to android inputType to use valid phone number #1002

Closed
wants to merge 1 commit into from
Closed

Cleanup android editable to android inputType to use valid phone number #1002

wants to merge 1 commit into from

Conversation

CalebKL
Copy link
Contributor

@CalebKL CalebKL commented Apr 17, 2023

This PR updates android:editable which has been deprecated to use android: inputType on the Contact phone number TextField. This would ensure the user would enter a valid phone number.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Fixes #1001 馃

@davkutalek
Copy link
Member

@Mzazi25 the StaxDropdownLayout is used by more than just the contact input, so this likely breaks some of its usages. The use of editable is to change it between a freeform input with autocomplete options and a regular dropdown with only preset options. Even the contact case it is more complicated: if a contact is chosen from the address book then it shows the contact's name in the input field.

@jumaallan is in the middle of converting the entire flow to compose anyway, so probably not worth the time to try to sort out the different use cases or get rid of the depreciated editable option

@CalebKL
Copy link
Contributor Author

CalebKL commented Apr 17, 2023 •
edited

@davkutalek thanks for clearing that up. Appreciate it. I will close the PR

@CalebKL CalebKL closed this Apr 17, 2023
@CalebKL CalebKL deleted the contactInputUpdate branch April 18, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User can input invalid inputs on the contact phone number TextField on the Send Money page.
2 participants
@CalebKL @davkutalek