Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kosovo country code XK #2028

Open
Ignigena opened this issue Jul 11, 2023 · 0 comments
Open

Add support for Kosovo country code XK #2028

Ignigena opened this issue Jul 11, 2023 · 0 comments

Comments

@Ignigena
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When using the CountryCode scalar, errors are thrown whenever the XK country code is returned.

The ISO standard has not assigned Kosovo a permanent country code (FIPS has assigned KV) so the EU, IMF and SWIFT have temporarily adopted one of the unused codes which ISO has made available for "user specified elements":

If users need code elements to represent country names not included in this part of ISO 3166, the series of letters AA, QM to QZ, XA to XZ, and ZZ, and the series AAA to AAZ, QMA to QZZ, XAA to XZZ, and ZZA to ZZZ respectively and the series of numbers 900 to 999 are available.

Describe the solution you'd like

Allow XK to be returned as a valid country code, update as necessary when a permanent assignment is made by the ISO standard.

Describe alternatives you've considered

It may be worth considering allowing any of the unused codes to be returned since this is part of the spec. While this would be a bit more than just updating the hardcoded regex set, it would further differentiate between the official ISO assignments and those that are not standard according to ISO but may have been adopted for use by other organizations.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant