Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN re-submit #112

Open
mpadge opened this issue Sep 8, 2023 · 2 comments
Open

CRAN re-submit #112

mpadge opened this issue Sep 8, 2023 · 2 comments

Comments

@mpadge
Copy link
Member

mpadge commented Sep 8, 2023

Got kicked off because of #111. Have to re-instate it.

@mpadge
Copy link
Member Author

mpadge commented Sep 15, 2023

CRAN email 14/9/23:

Please add \value to .Rd files regarding exported methods and explain the functions results in the documentation. Please write about the structure of the output (class) and also what the output means. (If a function does not return a value, please document that too, e.g. \value{No return value, called for side effects} or similar)
Missing Rd-tags:
gtfs_traveltimes.Rd: \value
process_gtfs_local.Rd: \value
summary.gtfs.Rd: \value

Please always make sure to reset to user's options(), working directory or par() after you changed it in examples and vignettes and demos. ->
e.g.:
oldpar <- par(mfrow = c(1,2))
...
par(oldpar)

Please fix and resubmit.

mpadge added a commit that referenced this issue Sep 15, 2023
mpadge added a commit that referenced this issue Sep 15, 2023
mpadge added a commit that referenced this issue Sep 15, 2023
mpadge added a commit that referenced this issue Sep 15, 2023
mpadge added a commit that referenced this issue Sep 15, 2023
mpadge added a commit that referenced this issue Sep 15, 2023
@mpadge
Copy link
Member Author

mpadge commented Sep 21, 2023

Possibly misspelled words in DESCRIPTION:
GTFS (2:21, 10:18)
isochrones (12:5)

Examples with CPU time > 2.5 times elapsed time
user system elapsed ratio
gtfs_route 1.223 0.037 0.38 3.316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant