Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verification check to save memory #128

Open
tomdeakin opened this issue Apr 4, 2022 · 1 comment
Open

Update verification check to save memory #128

tomdeakin opened this issue Apr 4, 2022 · 1 comment
Milestone
v6.0

Comments

@tomdeakin
Copy link
Contributor

The OpenMP CPU version allocates twice the memory it needs restricting the maximum problem size.

For offload models, this is OK as the data needs to exists on the device during the run and on the host during verification.

This could be solved by asking the implementations to pass a pointer to host data back to the driver routine for checking, rather than copying into a vector allocated by the driver.
This would allow implementations to do save memory where possible.
@tomdeakin
Copy link
Contributor Author

Refers to this: https://github.com/UoB-HPC/BabelStream/blob/7d570547edf0f0222d022d8cd1d67f768e666738/src/main.cpp#L330C3-L330C3

@tomdeakin tomdeakin added this to the v6.0 milestone Oct 6, 2023
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 3, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
b466f6e 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
@gonzalobg gonzalobg mentioned this issue Jun 3, 2024
Open
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 3, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
bbd0ffa 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 3, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
d5b776c 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 4, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
d651b7f 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 4, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
1c4220b 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 4, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
9a830e3 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 4, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
2b9129e 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 4, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
6c83420 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
gonzalobg added a commit to gonzalobg/BabelStream that referenced this issue Jun 4, 2024
@gonzalobg
Move host-side allocation to benchmarks and reuse device with UVM
616b3b2 
This commit puts benchmarks in control of allocating the host
memory used for verifying the results.

This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.

Closes UoB-HPC#128 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0
Development

No branches or pull requests
1 participant
@tomdeakin