Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when working with non-English filenames (preview error) #4034

Open
u3712 opened this issue Aug 19, 2023 · 17 comments
Open

Errors when working with non-English filenames (preview error) #4034

u3712 opened this issue Aug 19, 2023 · 17 comments

Comments

@u3712
Copy link

u3712 commented Aug 19, 2023

ums_dbg_2023-08-19-21-49.zip
img

When displaying a movie catalog, UMS creates preview images. If there are only English characters in the file name, pictures are generated correctly. If there are not many (little) non-English characters, the error is not seen. But if there are many characters, more than 10 (15?), then the preview image is not created. Interestingly, the error depends not so much on the number of characters, but on their mutual influence. I have not been able to identify a strict rule. It does not depend on the content of the movie.
This crash occurs in any version of UMS, it was "always". I really hoped that someday it would be fixed, but this has not happened so far.
Remark.
I looked at the first page of the conference, bugreport #3912 caught my eye. It seems to me that there is the same problem - an error in the file name.
Please see the mechanism for reading file names not only English characters.
Thanks for the program - a very good product.

@SubJunk
Copy link
Member

SubJunk commented Aug 19, 2023

@u3712 thanks for reporting this bug. Can you please paste one of the filenames that causes the problem?

@u3712
Copy link
Author

u3712 commented Aug 20, 2023 via email

@SubJunk
Copy link
Member

SubJunk commented Aug 25, 2023

Interesting, I can't reproduce it if I just rename my files to those names:
image

I think in the logs it is showing the cached result, so I don't see the error. Can you please make new logs after moving a file to another folder, so that I can see UMS regenerating the thumbnails?

@u3712
Copy link
Author

u3712 commented Aug 26, 2023

  1. turned off UMS
  2. created a new directory "Test"
  3. copied short movie orig.avi
  4. in windows explorer, copied orig.avi to several other files.
  5. changed the name to test ones. Added a new version with a short name.
  6. turned on UMS. I enabled tracing.
  7. I chose UMS on the TV - all contents - ... directory "Test". Only 2 pictures are shown, everything else is a "failure".
  8. saved the logs.
    The test film is small, I enclose it.
    If you need to do something differently, please let me know.
    ums_dbg_2023-08-26-09-54.zip
    img2
    orig.zip

@SubJunk
Copy link
Member

SubJunk commented Aug 28, 2023

I don't see any errors with the thumbnail generation, but maybe the problem is that the URL we provide to the TV isn't good. I can see in the logs this:

  <item id="55" parentID="47" restricted="1">
    <dc:title>4x01 - Прошлост</dc:title>
    <sec:dcmInfo>CREATIONDATE=0,FOLDER=4x01 - Прошлост,BM=0</sec:dcmInfo>
    <dc:date>2023-08-26T09:33:28</dc:date>
    <upnp:playbackCount>0</upnp:playbackCount>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" bitrate="26847" colorDepth="8" duration="0:00:10.000" framerate="25p" protocolInfo="http-get:*:video/avi:DLNA.ORG_OP=01" resolution="720x576" size="268470">http://192.168.100.65:5001/get/55/4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/jpeg:DLNA.ORG_PN=JPEG_SM;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="320x256" size="8467">http://192.168.100.65:5001/get/55/thumbnail0000JPEG_SM_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.jpg</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/jpeg:DLNA.ORG_PN=JPEG_TN;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="160x128">http://192.168.100.65:5001/get/55/thumbnail0000JPEG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.jpg</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/png:DLNA.ORG_PN=PNG_LRG;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="320x256">http://192.168.100.65:5001/get/55/thumbnail0000PNG_LRG_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.png</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/png:DLNA.ORG_PN=PNG_TN;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="160x128">http://192.168.100.65:5001/get/55/thumbnail0000PNG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.png</res>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="JPEG_SM">http://192.168.100.65:5001/get/55/thumbnail0000JPEG_SM_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.jpg</upnp:albumArtURI>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="JPEG_TN">http://192.168.100.65:5001/get/55/thumbnail0000JPEG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.jpg</upnp:albumArtURI>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="PNG_LRG">http://192.168.100.65:5001/get/55/thumbnail0000PNG_LRG_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.png</upnp:albumArtURI>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="PNG_TN">http://192.168.100.65:5001/get/55/thumbnail0000PNG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.png</upnp:albumArtURI>
    <upnp:class>object.item.videoItem</upnp:class>
  </item>
  <item id="56" parentID="47" restricted="1">
    <dc:title>4x01 - Прошлост је родитељ (The Past Is Parent)</dc:title>
    <sec:dcmInfo>CREATIONDATE=0,FOLDER=4x01 - Прошлост је родитељ (The Past Is Parent),BM=0</sec:dcmInfo>
    <dc:date>2023-08-26T09:33:28</dc:date>
    <upnp:playbackCount>0</upnp:playbackCount>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" bitrate="26847" colorDepth="8" duration="0:00:10.000" framerate="25p" protocolInfo="http-get:*:video/avi:DLNA.ORG_OP=01" resolution="720x576" size="268470">http://192.168.100.65:5001/get/56/4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/jpeg:DLNA.ORG_PN=JPEG_SM;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="320x256" size="8467">http://192.168.100.65:5001/get/56/thumbnail0000JPEG_SM_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.jpg</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/jpeg:DLNA.ORG_PN=JPEG_TN;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="160x128">http://192.168.100.65:5001/get/56/thumbnail0000JPEG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.jpg</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/png:DLNA.ORG_PN=PNG_LRG;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="320x256">http://192.168.100.65:5001/get/56/thumbnail0000PNG_LRG_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.png</res>
    <res xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" protocolInfo="http-get:*:image/png:DLNA.ORG_PN=PNG_TN;DLNA.ORG_CI=1;DLNA.ORG_FLAGS=00900000000000000000000000000000" resolution="160x128">http://192.168.100.65:5001/get/56/thumbnail0000PNG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.png</res>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="JPEG_SM">http://192.168.100.65:5001/get/56/thumbnail0000JPEG_SM_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.jpg</upnp:albumArtURI>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="JPEG_TN">http://192.168.100.65:5001/get/56/thumbnail0000JPEG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.jpg</upnp:albumArtURI>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="PNG_LRG">http://192.168.100.65:5001/get/56/thumbnail0000PNG_LRG_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.png</upnp:albumArtURI>
    <upnp:albumArtURI xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/" dlna:profileID="PNG_TN">http://192.168.100.65:5001/get/56/thumbnail0000PNG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.png</upnp:albumArtURI>
    <upnp:class>object.item.videoItem</upnp:class>
  </item>

That is the details we send to the TV. These URLs can be different each time UMS runs, so you might have to get the current URLs from the logs yourself. My idea is that maybe some of the special characters are not being encoded properly. You can try them in a browser, e.g. open up these in a browser (but fresh ones from your logs, because the /get/55 part may be different) and see if the thumbnails load:
http://192.168.100.65:5001/get/55/thumbnail0000PNG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82.avi.png
http://192.168.100.65:5001/get/56/thumbnail0000PNG_TN_4x01+-+%D0%9F%D1%80%D0%BE%D1%88%D0%BB%D0%BE%D1%81%D1%82+%D1%98%D0%B5+%D1%80%D0%BE%D0%B4%D0%B8%D1%82%D0%B5%D1%99+%28The+Past+Is+Parent%29.avi.png

That will test the theory

@u3712
Copy link
Author

u3712 commented Aug 28, 2023

34
Maybe a problem with brackets '('')'?

@SubJunk
Copy link
Member

SubJunk commented Aug 28, 2023

That might be the reason, but does the video play properly? It is weird if it accepts the video but not the image, because the video also has that same URL with brackets encoded.

I see on the Samsung website, the TV has a firmware update from this year, are you using it? Maybe they fixed the bug https://www.samsung.com/uk/support/model/UE39F5300AKXXU/#downloads

@u3712
Copy link
Author

u3712 commented Aug 28, 2023

The update will not help, this is a general malfunction. Yes, and you can not update - there is no update for my model.
I have a second TV, a Samsung UE32H6200 - it's significantly "newer" and will render all fonts just fine. If on my test example squares were displayed, then the UE32H6200 outputs everything normally. Now about the problem itself - both TVs show preview pictures in exactly the same way.
Second. I placed in the test directory not only films, but also pictures. I called them the same, but with the extension **.avi.png. Exactly the same happens as with "movies" - 3 examples do not show a preview, 2 examples do. Everything is exactly the same and the same as with avi files. At the same time, these pictures normally open and are shown on the TV (by the play button).
I tried to remove the parentheses "()" from the names - nothing changed.

@SubJunk
Copy link
Member

SubJunk commented Aug 29, 2023

@u3712 since the URLs work via a web browser I think we have isolated the problem as a bug on the TVs. I made this build of UMS to test, which will hopefully serve the thumbnails without the filename part, it should be like http://192.168.100.65:5001/get/55/thumbnail0000PNG_TN_fakename.png
https://www.universalmediaserver.com/uploads/UMS-4034-u3712.exe

@u3712
Copy link
Author

u3712 commented Aug 29, 2023

44
The names are the same:
4x01*= movies 4x01.....avi
4x02*= pictures 4x02.....avi.png
4x03*= pictures 4x02.....avi.png, but without brackets ()
I look through the catalogs, I did not see a single failure (movies).
There are no errors. Thank you!

@SubJunk
Copy link
Member

SubJunk commented Aug 30, 2023

Ah cool, so the TV doesn't like one of the encoded characters. I will have to come up with a better fix then, because it is still good to use dynamic names. I will upload another fix to test soon, and if that works I will put it in the next release

@u3712
Copy link
Author

u3712 commented Aug 30, 2023

No, it's much more complicated.
I took one name "4x02 - Прошлост је родитељ.avi.png" and made two new folders with copying of this name. In one folder, I replaced one character per number ("4x02 - Пр2шл2ст је р2дитељ" : "о"->"2"), if the letter occurs several times, they all change to a number. In this directory, ALL pictures gave an error.
Then I took the short name "4x02 - Прошлост.avi.png" and began to add 1 character from the full name. The name "4x02 - Прошлост је родит.avi.png" failed. Can I say "т" = failure? How no matter what, I added the name "4x02 - Прошлост је родии.avi.png" to the directory (instead of the last "т" I copied the previous "и"). And this name also fails! Although the name "4x02 - Прошлост је роди.avi.png" does not fail.

@u3712
Copy link
Author

u3712 commented Sep 16, 2023

Please add(!) this correction to the normal version of UMS. In the current version of UMS (13.6.0), working with non-English characters does not work, and the version you issued "UMS-4034" contains many critical errors. For example, this is what the file viewing marks look like on the “UMS-4034”:
60
All episodes have been watched in full, the last 4 episodes on UMS v10.0.0. I won’t list other mistakes so as not to spoil the mood.

add:
... as well as wasted time on issue #4060.

@SubJunk
Copy link
Member

SubJunk commented Sep 20, 2023

@u3712 I don't understand why this is related to #4060 can you explain?

@u3712
Copy link
Author

u3712 commented Sep 20, 2023

I'm sorry for your wasted time. Everything described in #4060 happens only in the test version of the program that you gave earlier to check the formation of thumbnails. The official version 13.6.0 does not have these problems; version 13.6.0 works stably with all files (but displaying non-English thumbnails does not work).
You wasted time trying to fix mistakes that don't exist. I'm sorry, please forgive me. I used the test version because it shows normal thumbnails, but then it turned out that it doesn’t work very well and I wrote report #4060. But I could not think that these errors were related specifically to the “test version” of the program. My fault. Report #4060 does not need to be corrected; the program does not contain the errors that I wrote.

@SubJunk
Copy link
Member

SubJunk commented Sep 21, 2023

Ah I see. Thank you for explaining. There is nothing to forgive, it's an easy mistake to make!

@u3712
Copy link
Author

u3712 commented Oct 26, 2023

For information.
2 months have passed, I installed a new version of UMS (13.7.0), the fix from this topic (4034) does not work. It didn't work in the previous version either. I'm really looking forward to the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants