Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP tutorial feedback / minor issues #53

Open
Sohojoe opened this issue Feb 14, 2019 · 3 comments
Open

GCP tutorial feedback / minor issues #53

Sohojoe opened this issue Feb 14, 2019 · 3 comments
Assignees

Comments

@Sohojoe
Copy link

Sohojoe commented Feb 14, 2019

From GCP tutorial

  1. [bug] The tutorial references an old release
wget https://storage.googleapis.com/obstacle-tower-build/v1/obstacletower_v1_linux.zip
unzip obstacletower_v1_linux.zip

should be

wget https://storage.googleapis.com/obstacle-tower-build/v1.1/obstacletower_v1.1_linux.zip
unzip obstacletower_v1.1_linux.zip
  1. [bug] Install the Obstacle Tower Environment is missing cd obstacle-tower-env
git clone https://github.com/Unity-Technologies/obstacle-tower-env
pip3 install ./ 
cd ../

should be

git clone https://github.com/Unity-Technologies/obstacle-tower-env
cd obstacle-tower-env
pip3 install ./ 
cd ../
  1. [recomendation/discussion] I believe the config will run for 50m steps by default - maybe the tutorial should override this with 10m steps (as this seems to be what was recommended)
@awjuliani
Copy link
Contributor

Thanks for pointing these issues out, @Sohojoe.

@ervteng Could you take a look and make the appropriate changes?

@ervteng
Copy link
Contributor

ervteng commented Feb 19, 2019

@Sohojoe thanks for pointing out these issues!

For the config, I've put it to more than 10M intentionally, since depending on environment (e.g. for a fixed seed) the agent may continue to learn well past 10M. I erred on the side of too many steps, as you can always kill a run but it would be very disappointing to wake up in the morning and find that your run has stopped prematurely! I've added a blurb in the documentation describing how to change this.

@Sohojoe
Copy link
Author

Sohojoe commented Feb 20, 2019

@ervteng that sounds good - I think the main thing is to have it clear in the guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants