Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of old style random number seeding in documentation #64

Open
mikecroucher opened this issue Feb 12, 2024 · 1 comment
Open

Use of old style random number seeding in documentation #64

mikecroucher opened this issue Feb 12, 2024 · 1 comment

Comments

@mikecroucher
Copy link

I noticed in the documentation for LXS https://github.com/UniprJRC/FSDA/blob/master/toolbox/regression/LXS.m that you use the old style of seeding for random number generation

randn('state', 123456);

This is a bad idea since it doesn't just seed the RNG, it actually changes the algorithm for random numbers generation to a very old one. Details at https://walkingrandomly.com/?p=2945

I suggest you do the following instead

rng(123456)

@MarcoRianiUNIPR
Copy link
Collaborator

MarcoRianiUNIPR commented Feb 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants