Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisVis with PyQt5 #53

Open
JarrettR opened this issue Sep 1, 2017 · 1 comment
Open

VisVis with PyQt5 #53

JarrettR opened this issue Sep 1, 2017 · 1 comment

Comments

@JarrettR
Copy link

JarrettR commented Sep 1, 2017

This doesn't run.

There are three causes:

  1. ControlVisVis loading the default conf and then immediately checking it (default is set to PyQt4)
    https://github.com/UmSenhorQualquer/pyforms/blob/master/pyforms/gui/Controls/ControlVisVis.py#L22
    I don't know offhand how to elegantly solve this.

  2. Base object QtGUI being referenced instead of the child
    https://github.com/UmSenhorQualquer/pyforms/blob/master/pyforms/gui/Controls/ControlVisVis.py#L31
    Solved by simply removing the QtGui. in front of QtGui.QWidget() and other instances

  3. Passing VisVis hardcoded Qt4 string
    https://github.com/UmSenhorQualquer/pyforms/blob/master/pyforms/gui/Controls/ControlVisVis.py#L40
    Also easily solved by adding the if conf.PYFORMS_USE_QT5: conditional to self._app = vv.use('pyqt4')

@abr123
Copy link

abr123 commented Sep 22, 2017

I totally agree with @JarrettR . No.2 and 3 changes are small, but can help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants