Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titlebar and frame on KDE Plasma Wayland #1261

Open
2 tasks done
friday opened this issue Aug 14, 2023 · 6 comments
Open
2 tasks done

Titlebar and frame on KDE Plasma Wayland #1261

friday opened this issue Aug 14, 2023 · 6 comments
Labels
enhancement Improvement to an existing feature

Comments

@friday
Copy link
Member

friday commented Aug 14, 2023

Description

I tested on KDE Plasma Wayland and got the border there (Only happen on pure Wayland. not X11 or XWayland)

Ulauncher version 6.0.0
GTK+ 3.24.37
PyGObject+ 3.44.1
Layer shell: No
X11 backend: No
...
Operating System: Kubuntu 23.04
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 6.2.0-20-generic (64-bit)
Graphics Platform: Wayland

Screenshot_20230814_224216

If you click the W there's a menu "More actions" and an option saying "No titlebar and frame" that shows this:
Screenshot_20230814_224152
But it doesn't actually do anything. The frame and titlebar is still there after.

I found a workaround for this:
System Settings > Window Management > Window Rule > Add New
Window class (application): "Exact Match" "Ulauncher"
Match whole window class: No
Window types: Normal Window

Then "Add Property..." and select "No titlebar and frame" and "Keep above other windows".

Lastly, "Apply"

Screenshot_20230814_234410

This still allowed me to move the window, and worked perfectly (better than on Gnome), and strangely it is not using GtkLayerShell (it can import it, but it has no is_supported method).
However, it is also applied to the settings window, where we want the titlebar (can't close or move it without it).

Outdated guide to do this (good enough to find how to do it still): https://medium.com/@CodyReichert/how-to-hide-title-bars-in-kde-plasma-5-348e0df4087f

Update: One of our users who are on KDE Wayland said #1331 (comment)

I don't get this issue when I launch from the gui, or from auto-start, but I do get it when launching from console, which is admittedly kinda curious. Happy to do more testing if you want me to.

Communication guidelines

Ulauncher v6

  • I have checked and couldn't find my suggestion in v6.
@friday friday added the enhancement Improvement to an existing feature label Aug 14, 2023
@fybx
Copy link

fybx commented Sep 6, 2023

This issue is present in Hyprland on Wayland.

Starting Ulauncher in hyprland.conf using this:

exec-once = launcher --hide-window --no-window-shadow

and binding to ulauncher-toggle fixed it.

@KAGEYAM4
Copy link

This issue is present in Hyprland on Wayland.

Starting Ulauncher in hyprland.conf using this:

exec-once = launcher --hide-window --no-window-shadow

and binding to ulauncher-toggle fixed it.

sorry going offtopic on this issue, i am also on hyprland and thes search ulauncher window bounces up and down when i type characters. Is there any way to fix this ?

@friday
Copy link
Member Author

friday commented Dec 19, 2023

sorry going offtopic on this issue, i am also on hyprland and thes search ulauncher window bounces up and down when i type characters. Is there any way to fix this ?

Hyprland had some issues with apps that resize themselves (including Ulauncher). Ex: hyprwm/Hyprland#4164 It sound like this could be related to that (although not as this issue is described).

@cosmicvibes
Copy link

Showing the titlebar and frame still seems to be the default behaviour on Plasma 5.27.11/ Wayland / Ubuntu 24.04.

I'm a little unclear if this is expected behaviour or not? I can create a window rule in KDE Plasma to hide the borders, which works.... though has the effect that there is no way to close the settings window as there is no window border!

@friday
Copy link
Member Author

friday commented Apr 29, 2024

I'm a little unclear if this is expected behavior or not

It's not a bug in Ulauncher, but if there's anything we can do (which I think there is), then we should.

Nothing is actively being worked on, but I have been making refactoring to isolate the Preferences window from the rest of the app. I think that completing this could fix the issue so setting one of them to "No titlebar and frame" wouldn't affect the other.

I think if we could use "window types" instead though, that would be better. I'm not sure what this is. I tried setting things in GTK that could change it.

friday added a commit that referenced this issue Apr 29, 2024
@friday
Copy link
Member Author

friday commented Apr 29, 2024

@cosmicvibes I just tested with Ulauncher v6 beta in Plasma v6 and this issue has been fully fixed (working as intended without making any system settings) for both X11 and Wayland. I think it's a safe assumption that they won't be backporting that to Plasma v5, and Plasma 6 is not in Kubuntu 24.04 (maybe 24.10).

If you check out the branch wip/experimental-plasma5-titlebar-frame-workaround (there is no PR because this is not meant to go into the development branch for Ulauncher) and run it instructions here, I would be curious if this fixes the issue so "Window Rule" is only applied for the launcher, but not the Preferences ui?

If not I think at least running ./bin/ulauncher-preferences-ui should be separate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants