Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Age of when photo taken #70

Open
MYLE-01 opened this issue Dec 19, 2022 · 10 comments
Open

Add Age of when photo taken #70

MYLE-01 opened this issue Dec 19, 2022 · 10 comments
Assignees

Comments

@MYLE-01
Copy link

MYLE-01 commented Dec 19, 2022

what about if we add the Year the photo was taken. then when we tag the person it could work out there age base on birth

@hartenthaler
Copy link

I'm adding already the date a picture was taken using a _DATE tag.

@MYLE-01
Copy link
Author

MYLE-01 commented Dec 20, 2022

Thanks, Bro could we have the option to add manually Year

Just that the Photos I'm uploading are Photos of the photo so _DATE would be wrong

@hartenthaler
Copy link

Yes, I'm adding the date a picture was taken manually. Sometimes the date is written on the back side of the photo. Or I know the event when the photo was taken. Since the GEDCOM standard 5.5.1 does not allow storing the date, I have to use a NOTE or a custom GEDCOM tag like _DATE.

@hartenthaler
Copy link

I agree that it would be nice if the faces module would show the age of the tagged persons in a picture together with their names. This could help to be sure that the identification of the persons is correct.

@UksusoFF
Copy link
Owner

Faces can show date from fact attached to photo.
So it's not so hard implement age on titles.
I will try implement it when possible.

@MYLE-01
Copy link
Author

MYLE-01 commented Dec 23, 2022

My thinking would be to add the Year to the Notes field

image

new note data looks like this
Y2005, X9, X10, X2, X11, X16, X55

I'm thinking the logic looks at that split it by the , if the first array has a Y then do the maths base on the X??

Would like to know what files you are changing to get to work?

@hartenthaler
Copy link

hartenthaler commented Dec 23, 2022

I do not understand what you mean. The date a picture is taken is an attribute of the picture. So it has to be stored as a GEDCOM tag in the OBJE record of the picture.

At the moment the data of the faces module is stored in a database table and cannot be exported as GEDCOM. This makes it complicated when transferring data to another installation of webtrees. This was ok, because there was no standard defined for that. Now there is GEDCOM 7 and so we have a standard for exchanging data like the position of "faces" in a picture. So I suggest orienting the module on that. even if webtrees is following the GEDCOM 5.5.1 standard up to now.

@UksusoFF
Copy link
Owner

@hartenthaler
GEDCOM 7 is supported with webtreees? Can you give example of this?

@hartenthaler
Copy link

webtrees is still supporting officially only 5.5.1. But there are already several 7.0 structures possible.

You can import GEDCOM 7.0 in webtrees (but not gedzip format) and export it without any errors (see German webtrees manual).

Support for GEDCOM 7.0

  • TIME is supported under DATE, so you can use time of birth or death; for example INDI:BIRT:DATE:TIME
  • you can export GEDCOM files in zipped format (GEDCOM file together with media files)
  • you can use RESN in all types of records
  • you can use FAM:FACT already now
  • you can activate the tags and rules of the GEDCOM-L group in webtrees; several definitions in this addendum to the GEDCOM 5.5.1 standard got part of GEDCOM 7.0
  • regarding sex: additionally to M, F, and U you can use "X" as it is defined in GEDCOM 7.0
  • all the enum fields are using already UPPERCASE, like in NAME:TYPE ("BIRTH") or when defining the OBJE:FORM tag (JPG instead of jpg)
  • the new tags EXID and SNOTE are supported
  • and many more ...

@UksusoFF
Copy link
Owner

@MYLE-01
Check latest master version
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants