Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Templatize settings and enable skip to step #188

Open
kartik-v opened this issue Aug 1, 2023 · 2 comments
Open

Feature: Templatize settings and enable skip to step #188

kartik-v opened this issue Aug 1, 2023 · 2 comments
Labels
feature Improvement

Comments

@kartik-v
Copy link

kartik-v commented Aug 1, 2023

First of all, congratulations on a great library and thanks to everyone involved in the creation of the components.

The feature I wish to present is templatizing a previous uploaded mapping/configuration to a saved setting and reusing it to skip to steps.

The use case will be a standard XLS file (say from a bank statement) - and you have a standard format for Citibank and another standard format for another Bank XYZ.

As a start will these be possible to save as a template and use that as an initial state

  • Ability to save column mappings
  • Ability to save header row position
  • Ability to skip and/or hide certain rows based on a callback function - (e.g. clear/hide rows with date field null)
  • Ability to skip to the step (say step 3 or step 4 directly after a file is selected).
@kartik-v
Copy link
Author

kartik-v commented Aug 1, 2023

I see the initialState setting to achieve some part of above - but still see bit of challenge separating the settings from table data in file. For example, the header row, column mappings should be separately configurable - any leads to help if I missed something will be great.

@JulitorK JulitorK added the feature Improvement label Aug 22, 2023
@masiulis
Copy link
Contributor

masiulis commented Oct 20, 2023

Hey @kartik-v, thank you for a detailed description, sorry for a late reply. I think this can be split into multiple issues:

Ability to save column mappings

If you already know the column name exactly, you can add it to alternateMatches and it will get matched automatically. Storing what matches the user has selected is outside of this components scope, but you can always get the matched columns in matchColumnsStepHook, store them, and next time reuse them as alternateMatches.

Ability to save header row position

I think that's a good feature to have, I will add it.

Ability to skip and/or hide certain rows based on a callback function - (e.g. clear/hide rows with date field null)

You can remove rows based on this logic in matchColumnsStepHook step before rows go to the validation step.

Ability to skip to the step (say step 3 or step 4 directly after a file is selected).

I can add flags to skip steps:

  • Skip header row select step - default selected header row will be configurable as mentioned previously.
  • Skip column select if everything was matched automatically.
  • Skip validation step if no errors were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Improvement
Projects
None yet
Development

No branches or pull requests

3 participants