Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Using filled rectangular boxes as markers #125

Open
Udayraj123 opened this issue Jan 26, 2023 · 2 comments
Open

[Feature] Using filled rectangular boxes as markers #125

Udayraj123 opened this issue Jan 26, 2023 · 2 comments

Comments

@Udayraj123
Copy link
Owner

Describe the bug
When using filled rectangular boxes as markers, omr_marker is getting detected incorrectly
Discord discussion: https://discord.com/channels/590134763784896514/1067501671627890731/1067971688169492480

To Reproduce
Steps to reproduce the behavior:

  1. Use any sample that contains rectangular filled markers
  2. Run omrchecker on that image
  3. See that the markers are not getting detected correctly.

Expected behavior
Markers should get matched as usual for other cases.
image

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [MacOS]
  • Python version: 3+
  • OpenCV version: 4+

Additional context

The template matching result is supposed to be a black image with white spots. But it is coming as a full white image.

image

Steps breakdown:
image

@Udayraj123
Copy link
Owner Author

There's a new plugin in development for solving this type of OMRs along with the ones having an timeline strip.

@Udayraj123 Udayraj123 changed the title [Bug] omr_marker is detected incorrectly for filled rectangular boxes as markers [Feature] Using filled rectangular boxes as markers Jun 25, 2023
@Udayraj123 Udayraj123 added enhancement New feature or request and removed bug Something isn't working labels Jun 25, 2023
@Udayraj123
Copy link
Owner Author

Udayraj123 commented Jun 25, 2023

Converting this issue into a feature.
Development tracked in branch: feature/crop-on-timeline --> feature/auto-align-template which tries to implement a generalised version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant