Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in VIC5 vic_init Zsum_node calculation #911

Open
BramDr opened this issue Mar 2, 2021 · 0 comments
Open

Bug in VIC5 vic_init Zsum_node calculation #911

BramDr opened this issue Mar 2, 2021 · 0 comments

Comments

@BramDr
Copy link

BramDr commented Mar 2, 2021

Dear Mr/Ms,

I have found another bug in the calculation of Zsum_node in the vic_init function (version VIC.5.0.1 - latest release)

Lines 845, 846, 848 of vic_init soil_con[0].depth[0] should be replaced with soil_con[i].depth[0]
Note that the soil_con index has changed from [0] to [i] (as it is everywhere else). Otherwise the dz_node and Zsum_node variables depths are determined by the first soil depth (of the area), instead of the current soil depth.
Maybe you can fix it in this repository?

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant