Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First timestep of disaggregation may end up constant. #223

Open
arbennett opened this issue May 20, 2020 · 0 comments
Open

First timestep of disaggregation may end up constant. #223

arbennett opened this issue May 20, 2020 · 0 comments

Comments

@arbennett
Copy link
Member

From Slack I wrote:

Okay, I now remember what was going on. Basically, we compute the time of sunrise and sunset for each day, and use a simple linear fit on vapor pressure to disaggregate. Now the problem occurs on the first timestep specifically because this has time periods before the first sunrise (generally). Then, when we do this linear fit, we just extrapolate back in time. Occasionally this can put you in a position of negative relative humidity, which would cause NaNs to get produced by longwave and humidity. So, to alleviate this we just backfilled as constant instead of linearly interpolating backwards.

However, the backfilling I implemented happens after all of the other caluclations. Instead we should backfill vapor pressure before calculating longwave, humidity, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant