-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent Data Management #145
Comments
Yes that lack of consistency in how the data are accessed is a bit of a relic and needs to be updated. This is especially true given #144 which is affecting multiple sources it seems. The goal will be to shift towards using data calls via esupy for consistency. I was just starting this on a new branch ( |
The RCRA selenium issue is one I am aware of but not yet documented. We regularly have issues accessing RCRA based on how that data is stored and provided. I have added a separate issue #146 |
The lack of consistency came from the original of the tool as a set of inventory specific and independent scripts written by authors who each approached data acquisition uniquely. Yes I agree we can reevaluate that as resources are available. |
1 similar comment
The lack of consistency came from the original of the tool as a set of inventory specific and independent scripts written by authors who each approached data acquisition uniquely. Yes I agree we can reevaluate that as resources are available. |
I'm not sure what the intended pathway is for data management, but seeing a general buy-in on esupy's data manager, I'm guessing that's the direction you are heading. That said, it doesn't seem like there is any commonality between approaches when looking across the main data modules (i.e., egrid, NEI, RCRAInfo, and TRI).
url
key, which does not point to a data file. It is stored in the uniquezip_url
keyword (not shared by other databases). It doesn't use esupy methods. It fails.Footnotes
https://www.selenium.dev/documentation/webdriver/ ↩
The text was updated successfully, but these errors were encountered: